Skip to content

B
business-java
Commit 7470fae6 authored by akhokar's avatar akhokar
Browse files
Options

Changes done for connection is not getting closed 

RecoPattItmChg.java
RecoveryPattern.java


git-svn-id: http://15.206.35.175/svn/proteus/business-java/trunk@200737 ce508802-f39f-4f6c-b175-0d175dae99d5
parent 4cd19aed
Hide whitespace changes
Inline Side-by-side
Showing with 65 additions and 41 deletions
webitm-adm/ibase/webitm/ejb/adm/RecoPattItmChg.java
View file @ 7470fae6
package ibase.webitm.ejb.adm; package ibase.webitm.ejb.adm;
import ibase.system.config.ConnDriver;
import ibase.webitm.ejb.ValidatorEJB;
import ibase.webitm.utility.GenericUtility;
import ibase.webitm.utility.ITMException;
import java.rmi.RemoteException; import java.rmi.RemoteException;
import java.sql.Connection; import java.sql.Connection;
import java.sql.PreparedStatement; import java.sql.PreparedStatement;
import java.sql.ResultSet; import java.sql.ResultSet;
import java.sql.*; import java.sql.SQLException;
import java.text.SimpleDateFormat;
import java.util.Date; import javax.ejb.Stateless; // added for ejb3
import java.util.GregorianCalendar;
import javax.ejb.CreateException;
//import javax.ejb.SessionBean; //import javax.ejb.SessionBean;
import org.w3c.dom.Document; import org.w3c.dom.Document;
import org.w3c.dom.Node; import org.w3c.dom.Node;
import org.w3c.dom.NodeList; import org.w3c.dom.NodeList;
import javax.ejb.Stateless; // added for ejb3
import ibase.webitm.ejb.ValidatorEJB;
import ibase.webitm.utility.GenericUtility;
import ibase.webitm.utility.ITMException;
@Stateless // added for ejb3 @Stateless // added for ejb3
public class RecoPattItmChg extends ValidatorEJB implements RecoPattItmChgLocal,RecoPattItmChgRemote //SessionBean public class RecoPattItmChg extends ValidatorEJB implements RecoPattItmChgLocal,RecoPattItmChgRemote //SessionBean
...@@ -84,13 +81,18 @@ public class RecoPattItmChg extends ValidatorEJB implements RecoPattItmChgLocal, ...@@ -84,13 +81,18 @@ public class RecoPattItmChg extends ValidatorEJB implements RecoPattItmChgLocal,
int currentFormNo = 0 ,cnt = 0; int currentFormNo = 0 ,cnt = 0;
String tranId="",deptCode = "", roleCodePrfmer = "", siteCode = "", empCode = ""; String tranId="",deptCode = "", roleCodePrfmer = "", siteCode = "", empCode = "";
String sql = "",descr = "",empFName = "", empMName = "", empLName = "",roleCodeAprv=""; String sql = "",descr = "",empFName = "", empMName = "", empLName = "",roleCodeAprv="";
ConnDriver connDriver = new ConnDriver(); //Modified by Azhar on [13-05-2019][To do changes for connection not getting closed][Start]
//ConnDriver connDriver = new ConnDriver();
//Modified by Azhar on [13-05-2019][To do changes for connection not getting closed][End]
try try
{ {
GenericUtility genericUtility = GenericUtility.getInstance(); GenericUtility genericUtility = GenericUtility.getInstance();
conn = connDriver.getConnectDB("DriverITM"); //Modified by Azhar on [13-05-2019][To do changes for connection not getting closed][Start]
//conn = connDriver.getConnectDB("DriverITM");
conn = getConnection();
conn.setAutoCommit(false); conn.setAutoCommit(false);
connDriver=null; //connDriver=null;
//Modified by Azhar on [13-05-2019][To do changes for connection not getting closed][End]
if(objContext != null && objContext.trim().length()>0) if(objContext != null && objContext.trim().length()>0)
{ {
currentFormNo = Integer.parseInt(objContext); currentFormNo = Integer.parseInt(objContext);
...@@ -143,6 +145,21 @@ public class RecoPattItmChg extends ValidatorEJB implements RecoPattItmChgLocal, ...@@ -143,6 +145,21 @@ public class RecoPattItmChg extends ValidatorEJB implements RecoPattItmChgLocal,
} }
finally finally
{ {
//Modified by Azhar on [13-05-2019][To do changes for connection not getting closed][Start]
try
{
if(conn != null)
{
conn.close();
conn = null;
}
}
catch (SQLException e)
{
e.printStackTrace();
throw new ITMException(e);
}
//Modified by Azhar on [13-05-2019][To do changes for connection not getting closed][End]
} }
return valueXmlString.toString(); return valueXmlString.toString();
}//END OF ITEMCHANGE }//END OF ITEMCHANGE
......
webitm-adm/ibase/webitm/ejb/adm/RecoveryPattern.java
View file @ 7470fae6
...@@ -7,27 +7,27 @@ ...@@ -7,27 +7,27 @@
********************************************************/ ********************************************************/
package ibase.webitm.ejb.adm; package ibase.webitm.ejb.adm;
import ibase.webitm.utility.*;
import ibase.utility.CommonConstants;
import ibase.webitm.ejb.*;
import ibase.system.config.*;
import java.rmi.RemoteException; import java.rmi.RemoteException;
import java.text.*; import java.sql.Connection;
import java.util.*; import java.sql.PreparedStatement;
import java.sql.*; import java.sql.ResultSet;
import org.w3c.dom.*; import java.sql.Statement;
import javax.xml.parsers.*; import java.sql.Timestamp;
import javax.ejb.*;
import javax.naming.InitialContext;
import java.io.*;
import javax.xml.transform.*;
import javax.xml.transform.dom.*;
import javax.xml.transform.TransformerFactory;
import javax.xml.transform.Transformer;
import java.text.DecimalFormat; import java.text.DecimalFormat;
import java.text.SimpleDateFormat;
import java.util.HashMap;
import javax.ejb.Stateless; // added for ejb3 import javax.ejb.Stateless; // added for ejb3
import org.w3c.dom.Document;
import org.w3c.dom.Node;
import org.w3c.dom.NodeList;
import ibase.webitm.ejb.ITMDBAccessEJB;
import ibase.webitm.ejb.ProcessEJB;
import ibase.webitm.utility.GenericUtility;
import ibase.webitm.utility.ITMException;
@Stateless // added for ejb3 @Stateless // added for ejb3
public class RecoveryPattern extends ProcessEJB implements RecoveryPatternLocal,RecoveryPatternRemote //SessionBean public class RecoveryPattern extends ProcessEJB implements RecoveryPatternLocal,RecoveryPatternRemote //SessionBean
{ {
...@@ -246,15 +246,19 @@ public class RecoveryPattern extends ProcessEJB implements RecoveryPatternLocal, ...@@ -246,15 +246,19 @@ public class RecoveryPattern extends ProcessEJB implements RecoveryPatternLocal,
String loginSiteCode = ""; String loginSiteCode = "";
String loginCode = ""; String loginCode = "";
DecimalFormat df = new DecimalFormat("0.00"); DecimalFormat df = new DecimalFormat("0.00");
ConnDriver connDriver = new ConnDriver(); //Modified by Azhar on [13-05-2019][To do changes for connection not getting closed][Start]
//ConnDriver connDriver = new ConnDriver();
//Modified by Azhar on [13-05-2019][To do changes for connection not getting closed][End]
try try
{ { //Modified by Azhar on [13-05-2019][To do changes for connection not getting closed][Start]
ConnDriver conndriver = new ConnDriver(); //ConnDriver conndriver = new ConnDriver();
System.out.println("oracle driver found:-" + conndriver); //System.out.println("oracle driver found:-" + conndriver);
conn = conndriver.getConnectDB("DriverITM"); //conn = conndriver.getConnectDB("DriverITM");
conn = getConnection();
System.out.println("U r connected to oracle :-" + conn ); System.out.println("U r connected to oracle :-" + conn );
conn.setAutoCommit(false); conn.setAutoCommit(false);
connDriver = null; //connDriver = null;
//Modified by Azhar on [13-05-2019][To do changes for connection not getting closed][End]
System.out.println("xtraParams :::::::::::::::::::::::::::::::::: "+xtraParams); System.out.println("xtraParams :::::::::::::::::::::::::::::::::: "+xtraParams);
loginSiteCode = genericUtility.getValueFromXTRA_PARAMS(xtraParams,"loginSiteCode"); loginSiteCode = genericUtility.getValueFromXTRA_PARAMS(xtraParams,"loginSiteCode");
empCodeStr = genericUtility.getValueFromXTRA_PARAMS(xtraParams,"loginEmpCode"); empCodeStr = genericUtility.getValueFromXTRA_PARAMS(xtraParams,"loginEmpCode");
...@@ -585,14 +589,17 @@ public class RecoveryPattern extends ProcessEJB implements RecoveryPatternLocal, ...@@ -585,14 +589,17 @@ public class RecoveryPattern extends ProcessEJB implements RecoveryPatternLocal,
{ {
retTabSepStrBuff = null; retTabSepStrBuff = null;
conn.rollback(); conn.rollback();
//Modified by Azhar on [13-05-2019][To do changes for connection not getting closed][Start]
if(conn != null) if(conn != null)
{ {
if(pstmt != null)
{
pstmt.close();
pstmt=null;
}
conn.close(); conn.close();
conn = null;
}
//Modified by Azhar on [13-05-2019][To do changes for connection not getting closed][End]
if(pstmt != null)
{
pstmt.close();
pstmt=null;
} }
} }
catch(Exception e) catch(Exception e)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment