Bug fixing - string comparision not with proper syntax instead of .equals ==...

Bug fixing - string comparision not with proper syntax instead of .equals == or != used which are corrected

git-svn-id: http://15.206.35.175/svn/proteus/business-java/trunk@196466 ce508802-f39f-4f6c-b175-0d175dae99d5

webitm-dis/ibase/webitm/ejb/dis/StockTransferEJB.java

@@ -396,8 +396,9 @@ public class StockTransferEJB extends ValidatorEJB implements StockTransferEJBRe
 								rs = null;
 								pstmt.close();
 								pstmt = null;
-
-								if (ls_iss_criteria == "W" && lc_Num != lc_stk_qty )
+								// 31-jan-2019 manoharan invalid syntax corrected
+								//if (ls_iss_criteria == "W" && lc_Num != lc_stk_qty )
+									if ("W".equals(ls_iss_criteria) && lc_Num != lc_stk_qty )
 								{
 									errList.add( "VTSTK02" );
 									errFields.add( childNodeName.toLowerCase() );
@@ -485,22 +486,28 @@ public class StockTransferEJB extends ValidatorEJB implements StockTransferEJBRe
 						{
 							ls_disparminvstat = " ";
 						}
-
-						if (ls_available_fr == "Y") 
+						// 31-jan-2019 manoharan invalid syntax corrected
+						//if (ls_available_fr == "Y") 
+						if ("Y".equals(ls_available_fr)) 
 						{
-							if ((ls_invstat_to.trim()) != (ls_disparminvstat.trim())) 
+							// 31-jan-2019 manoharan invalid syntax corrected
+							//if ((ls_invstat_to.trim()) != (ls_disparminvstat.trim())) 
+							if (!ls_invstat_to.trim().equals(ls_disparminvstat.trim())) 
 							{
 								errList.add( "VMLOCSTAT" );
 								errFields.add( childNodeName.toLowerCase() );
 							}
 						}
-						else if (ls_available_fr == "N") 
+						// 31-jan-2019 manoharan invalid syntax corrected
+						//else if (ls_available_fr == "N") 
+						else if ("N".equals(ls_available_fr)) 
 						{
 							errList.add( "VMLOCSTAT" );
 							errFields.add( childNodeName.toLowerCase() );
 						}
-
-						if ((ls_invstat_to.trim()) != (ls_disparminvstat.trim())) 
+						// 31-jan-2019 manoharan invalid syntax corrected
+						//if ((ls_invstat_to.trim()) != (ls_disparminvstat.trim())) 
+						if (!ls_invstat_to.trim().equals(ls_disparminvstat.trim())) 
 						{
 							errCode = getLocType(ls_item_code,ls_loccode,conn) ;
 							if(errCode == null && errCode.trim().length() == 0)
@@ -511,7 +518,9 @@ public class StockTransferEJB extends ValidatorEJB implements StockTransferEJBRe
 								ls_loc_code__to 	= 	genericUtility.getColumnValue( "loc_code__to", currDom );
 								ls_lot_no__to 		= 	genericUtility.getColumnValue( "lot_no__to", currDom );			
 								ls_lot_sl__to 		= 	genericUtility.getColumnValue( "lot_sl__to", currDom );			
-								if ((ls_Val.trim() == ls_loccode.trim()) &&	(ls_lot_no__fr.trim() == ls_lot_no__to.trim()) && (ls_lot_sl__fr.trim() == ls_lot_sl__to.trim())) 
+								// 31-jan-2019 manoharan invalid syntax corrected
+								//if ((ls_Val.trim() == ls_loccode.trim()) &&	(ls_lot_no__fr.trim() == ls_lot_no__to.trim()) && (ls_lot_sl__fr.trim() == ls_lot_sl__to.trim())) 
+								if (ls_Val.trim().equals(ls_loccode.trim()) && ls_lot_no__fr.trim().equals(ls_lot_no__to.trim()) && ls_lot_sl__fr.trim().equals(ls_lot_sl__to.trim())) 
 								{
 									errList.add( "VTITRF" );
 									errFields.add( childNodeName.toLowerCase() );
@@ -561,7 +570,9 @@ public class StockTransferEJB extends ValidatorEJB implements StockTransferEJBRe
 								{
 									ls_loc_group_to = " ";
 								}
-								if(ls_loc_group_fr.trim() != ls_loc_group_to.trim())
+								// 31-jan-2019 manoharan invalid syntax corrected
+								//if(ls_loc_group_fr.trim() != ls_loc_group_to.trim())
+								if(!ls_loc_group_fr.trim().equals(ls_loc_group_to.trim()))
 								{
 									errList.add( "VTLOCGRP2" );
 									errFields.add( childNodeName.toLowerCase());
@@ -591,7 +602,8 @@ public class StockTransferEJB extends ValidatorEJB implements StockTransferEJBRe
 							pstmt = null;
 							if (((ls_faci_loc_code != null) && (ls_faci_loc_code.trim().length()) > 0 ) && ((ls_faci_site_code != null)  && (ls_faci_loc_code.trim().length()) > 0 ) ) 
 							{
-								if (ls_faci_loc_code.trim() != ls_faci_site_code.trim()) 
+								// 31-jan-2019 manoharan invalid syntax corrected
+								if (!ls_faci_loc_code.trim().equals(ls_faci_site_code.trim()) )
 								{
 									errList.add( "VMFACI2" );
 									errFields.add( childNodeName.toLowerCase());
@@ -750,6 +762,7 @@ public class StockTransferEJB extends ValidatorEJB implements StockTransferEJBRe
 							}
 						}
 					}
+					/* // commented by manohar 31-jan-19 already same validation exists (loc_code__fr)
 					else if ( "lot_sl__to".equalsIgnoreCase( childNodeName ) ) 
 					{
 						ls_loc_code__fr 	= 	genericUtility.getColumnValue( "loc_code__fr", currDom );
@@ -758,7 +771,6 @@ public class StockTransferEJB extends ValidatorEJB implements StockTransferEJBRe
 						ls_loc_code__to 	= 	genericUtility.getColumnValue( "loc_code__to", currDom );
 						ls_lot_no__to 		= 	genericUtility.getColumnValue( "lot_no__to", currDom );			
 						ls_lot_sl__to 		= 	genericUtility.getColumnValue( "lot_sl__to", currDom );			
-
 						if((ls_loc_code__fr.trim() == ls_loc_code__to.trim()) && (ls_lot_no__fr.trim() == ls_lot_no__to.trim()) && (ls_lot_sl__fr.trim() == ls_lot_sl__to.trim()))
 						{
 							errList.add( "VTITRF" );
@@ -780,6 +792,7 @@ public class StockTransferEJB extends ValidatorEJB implements StockTransferEJBRe
 							errFields.add( childNodeName.toLowerCase());
 						}
 					}
+					*/
 					else if ( "cctr_code__inv".equalsIgnoreCase( childNodeName ) ) 
 					{
 						cctrCodeInv = genericUtility.getColumnValue( "cctr_code__inv", currDom );