modify as per review

git-svn-id: http://15.206.35.175/svn/proteus/business-java/trunk@32071 ce508802-f39f-4f6c-b175-0d175dae99d5

webitm-mfg/ibase/webitm/ejb/mfg/QCTransferConf.java

@@ -91,8 +91,8 @@ QCTransferConfLocal, QCTransferConfRemote
 					}	
 					else
 					{
-						errCode = gbf_confirm_qctransfer(tranId,1, xtraParams,conn);
-						System.out.println("@@@@ gbf_confirm_qctransfer::errCode["+errCode+"]");
+						errCode = confirmQcTransfer(tranId,1, xtraParams,conn);
+						System.out.println("@@@@ confirmQcTransfer::errCode["+errCode+"]");
 						if( errCode != null && errCode.trim().length() > 0 )
 						{
 							errString = itmDBAccessLocal.getErrorString("",errCode,"");
@@ -145,7 +145,7 @@ QCTransferConfLocal, QCTransferConfRemote
 			}
 
 
-	private String gbf_confirm_qctransfer(String tranId, int i, String xtraParams, Connection conn)
+	private String confirmQcTransfer(String tranId, int i, String xtraParams, Connection conn)
 			throws RemoteException, ITMException
 
 			{
@@ -164,7 +164,7 @@ QCTransferConfLocal, QCTransferConfRemote
 		{
 			StockUpdate stockUpdate = new StockUpdate();
 
-			System.out.println("@@@@@@@@@@@@@@@ gbf_confirm_qctransfer method called next..............");
+			System.out.println("@@@@@@@@@@@@@@@ confirmQcTransfer method called next..............");
 			Calendar currentDate = Calendar.getInstance();
 			SimpleDateFormat sdf = new SimpleDateFormat(genericUtility.getApplDateFormat());
 			String sysDateStr = sdf.format(currentDate.getTime());

webitm-mfg/ibase/webitm/ejb/mfg/QCTransferIC.java

@@ -353,7 +353,7 @@ public class QCTransferIC extends ValidatorEJB implements QCTransferICLocal, QCT
 							if (( lotSl != null && lotSl.trim().length() > 0 ) && (refNo != null && refNo.trim().length()>0))
 							{
 								// ls_errcode = gf_chk_pck_dtl(ls_sitecode,ls_itemcode,ls_loc,ls_lotno,ls_qorderno,ls_ref_no,ls_lot_sl)
-								errCode = gf_chk_pck_dtl(siteCode,itemCode,locCode,lotNo,qorderNo,refNo,lotSl,conn);
+								errCode = chkPckDtl(siteCode,itemCode,locCode,lotNo,qorderNo,refNo,lotSl,conn);
 								if( errCode != null && errCode.trim().length() > 0 )
 								{
 									System.out.println("@@@@@ errCode["+errCode+"]");
@@ -584,7 +584,7 @@ public class QCTransferIC extends ValidatorEJB implements QCTransferICLocal, QCT
 		return errString;
 	}//end of validation
 
-	private String gf_chk_pck_dtl(String siteCode, String itemCode,
+	private String chkPckDtl(String siteCode, String itemCode,
 			String locCode, String lotNo, String qorderNo, String refNo,
 			String lotSl,Connection conn) throws SQLException
 			{
@@ -833,7 +833,7 @@ public class QCTransferIC extends ValidatorEJB implements QCTransferICLocal, QCT
 						locCode =  setDescription("loc_code","qc_order","qorder_no", qorderNo, conn);
 					}
 
-					if ( locCode == null  || locCode.trim().length() > 0  )
+					if ( locCode == null  || locCode.trim().length() == 0  )
 					{
 						lotSl = genericUtility.getColumnValue("lot_sl", dom);
 						lotNo = genericUtility.getColumnValue("lot_no", dom);