Skip to content

B
business-java
Commit 7870ca97 authored by kshinde's avatar kshinde
Browse files
Options

Closing statements and replacing statements with prepared Statements 

git-svn-id: http://15.206.35.175/svn/proteus/business-java/trunk@196600 ce508802-f39f-4f6c-b175-0d175dae99d5
parent e17cfbb7
Show whitespace changes
Inline Side-by-side
Showing with 471 additions and 207 deletions
webitm-fin/ibase/webitm/ejb/fin/FinCommon.java
View file @ 7870ca97
...@@ -132,11 +132,19 @@ public class FinCommon ...@@ -132,11 +132,19 @@ public class FinCommon
{ {
// check for period 000000 // check for period 000000
sql = "SELECT COUNT(1) FROM SUNDRYBAL " sql = "SELECT COUNT(1) FROM SUNDRYBAL "
+ "WHERE ACCT_PRD = '"+ acctPrd +"' AND PRD_CODE = '"+ prdCode +"' AND FIN_ENTITY = '"+ finEntity +"' " + "WHERE ACCT_PRD = ? AND PRD_CODE = ? AND FIN_ENTITY = ? "
+ "AND SITE_CODE = '"+ siteCode +"' AND SUNDRY_TYPE = '"+ sundryType +"' AND SUNDRY_CODE = '"+ sundryCode +"' " + "AND SITE_CODE = ? AND SUNDRY_TYPE = ? AND SUNDRY_CODE = ? "
+ "AND ACCT_CODE = '"+ acctCode +"' AND CCTR_CODE = '"+ cctrCode +"'"; + "AND ACCT_CODE = ? AND CCTR_CODE = ? ";
pstmt = conn.prepareStatement(sql);
rs = stmt.executeQuery(sql); pstmt.setString(1, acctPrd);
pstmt.setString(2, prdCode);
pstmt.setString(3, finEntity);
pstmt.setString(4, siteCode);
pstmt.setString(5, sundryType);
pstmt.setString(6, sundryCode);
pstmt.setString(7, acctCode);
pstmt.setString(8, cctrCode);
rs = pstmt.executeQuery();
if (rs.next()) if (rs.next())
{ {
sundrybalCnt = rs.getInt(1); sundrybalCnt = rs.getInt(1);
...@@ -145,7 +153,7 @@ public class FinCommon ...@@ -145,7 +153,7 @@ public class FinCommon
//Modified by Anjali R. on [20/09/2018][Start] //Modified by Anjali R. on [20/09/2018][Start]
//stmt.close(); stmt = null; //stmt.close(); stmt = null;
rs.close(); rs = null; rs.close(); rs = null;
stmt.close(); stmt = null; pstmt.close(); pstmt = null;
//Modified by Anjali R. on [20/09/2018][End] //Modified by Anjali R. on [20/09/2018][End]
}//try }//try
catch(SQLException se) catch(SQLException se)
...@@ -631,17 +639,28 @@ public class FinCommon ...@@ -631,17 +639,28 @@ public class FinCommon
try try
{ {
// check for current period // check for current period
sql ="SELECT COUNT(1) FROM ACCTBAL WHERE ACCT_PRD = '"+acctPrd+"' AND PRD_CODE ='"+prdCode+"' AND "+ sql ="SELECT COUNT(1) FROM ACCTBAL WHERE ACCT_PRD = ? AND PRD_CODE = ? AND "+
"FIN_ENTITY = '"+acctVar_finentity+"' AND SITE_CODE ='"+acctVar_sitecode+"' AND ACCT_CODE = '"+acctVar_acctcode+"' "+ "FIN_ENTITY = ? AND SITE_CODE = ? AND ACCT_CODE = ? "+
"AND CCTR_CODE ='"+acctVar_cctrcode+"'"; "AND CCTR_CODE = ? ";
stmt = conn.createStatement(); //stmt = conn.createStatement();
rs = stmt.executeQuery(sql); //rs = stmt.executeQuery(sql);
pstmt = conn.prepareStatement(sql);
pstmt.setString(1, acctPrd);
pstmt.setString(2, prdCode);
pstmt.setString(3, acctVar_finentity);
pstmt.setString(4, acctVar_sitecode);
pstmt.setString(5, acctVar_acctcode);
pstmt.setString(6, acctVar_cctrcode);
rs= pstmt.executeQuery();
if (rs.next()) if (rs.next())
{ {
ll_cnt = rs.getInt(1); ll_cnt = rs.getInt(1);
} }
rs.close(); rs = null; rs.close(); rs = null;
stmt.close(); stmt = null; pstmt.close(); pstmt = null;
System.out.println("For Period 000000 ll_cnt : " + ll_cnt); System.out.println("For Period 000000 ll_cnt : " + ll_cnt);
}//try }//try
...@@ -795,14 +814,17 @@ public class FinCommon ...@@ -795,14 +814,17 @@ public class FinCommon
System.out.println("Closing acctVar_sitecode [" + acctVar_sitecode + "]"); System.out.println("Closing acctVar_sitecode [" + acctVar_sitecode + "]");
System.out.println("Closing acctVar_acctcode [" + acctVar_acctcode + "]"); System.out.println("Closing acctVar_acctcode [" + acctVar_acctcode + "]");
System.out.println("Closing acctVar_cctrcode [" + acctVar_cctrcode + "]"); System.out.println("Closing acctVar_cctrcode [" + acctVar_cctrcode + "]");
stmt = conn.createStatement(); //stmt = conn.createStatement();
rs = stmt.executeQuery(sql); //rs = stmt.executeQuery(sql);
pstmt= conn.prepareStatement(sql);
rs=pstmt.executeQuery();
if (rs.next()) if (rs.next())
{ {
ll_cnt = rs.getInt(1); ll_cnt = rs.getInt(1);
} }
rs.close(); rs = null; rs.close(); rs = null;
stmt.close(); stmt = null; pstmt.close(); pstmt = null;
System.out.println("For Period zzzzzz ll_cnt : " + ll_cnt); System.out.println("For Period zzzzzz ll_cnt : " + ll_cnt);
} }
...@@ -1130,13 +1152,23 @@ public class FinCommon ...@@ -1130,13 +1152,23 @@ public class FinCommon
+ "AND SITE_CODE = '"+ ls_sitecode +"' AND SUNDRY_TYPE = '"+ ls_sundrytype +"' AND SUNDRY_CODE = '"+ ls_sundrycode +"' " + "AND SITE_CODE = '"+ ls_sitecode +"' AND SUNDRY_TYPE = '"+ ls_sundrytype +"' AND SUNDRY_CODE = '"+ ls_sundrycode +"' "
+ "AND ACCT_CODE = '"+ ls_acctcode +"' AND CCTR_CODE = '"+ ls_cctrcode +"'"; + "AND ACCT_CODE = '"+ ls_acctcode +"' AND CCTR_CODE = '"+ ls_cctrcode +"'";
rs = stmt.executeQuery(sql); pstmt = conn.prepareStatement(sql);
pstmt.setString(1, ls_acctprd);
pstmt.setString(2, ls_openprd);
pstmt.setString(3, ls_finentity);
pstmt.setString(4, ls_sitecode);
pstmt.setString(5, ls_sundrytype);
pstmt.setString(6, ls_sundrycode);
pstmt.setString(7, ls_acctcode);
pstmt.setString(7, ls_cctrcode);
rs = pstmt.executeQuery();
//rs = stmt.executeQuery(sql);
if (rs.next()) if (rs.next())
{ {
ll_cnt = rs.getInt(1); ll_cnt = rs.getInt(1);
} }
stmt.close(); stmt = null;
rs.close(); rs = null; rs.close(); rs = null;
pstmt.close(); pstmt = null;
if (ll_cnt == 0 ) if (ll_cnt == 0 )
{ {
try try
...@@ -1215,14 +1247,16 @@ public class FinCommon ...@@ -1215,14 +1247,16 @@ public class FinCommon
+ "AND SITE_CODE = '"+ ls_sitecode +"' AND SUNDRY_TYPE = '"+ ls_sundrytype +"' AND SUNDRY_CODE = '"+ ls_sundrycode +"' " + "AND SITE_CODE = '"+ ls_sitecode +"' AND SUNDRY_TYPE = '"+ ls_sundrytype +"' AND SUNDRY_CODE = '"+ ls_sundrycode +"' "
+ "AND ACCT_CODE = '"+ ls_acctcode +"' AND CCTR_CODE = '"+ ls_cctrcode +"'"; + "AND ACCT_CODE = '"+ ls_acctcode +"' AND CCTR_CODE = '"+ ls_cctrcode +"'";
stmt = conn.createStatement(); // Added as stmt is closed and asigned null above - Piyush - 26/03/08 //stmt = conn.createStatement(); // Added as stmt is closed and asigned null above - Piyush - 26/03/08
rs = stmt.executeQuery(sql); //rs = stmt.executeQuery(sql);
pstmt= conn.prepareStatement(sql);
rs=pstmt.executeQuery();
if (rs.next()) if (rs.next())
{ {
ll_cnt = rs.getInt(1); ll_cnt = rs.getInt(1);
} }
stmt.close(); stmt = null;
rs.close(); rs = null; rs.close(); rs = null;
pstmt.close(); pstmt = null;
}//try }//try
catch(SQLException se) catch(SQLException se)
{ {
...@@ -1387,18 +1421,28 @@ public class FinCommon ...@@ -1387,18 +1421,28 @@ public class FinCommon
{ {
// check for closing balance // check for closing balance
sql = "SELECT COUNT(1) FROM SUNDRYBAL " sql = "SELECT COUNT(1) FROM SUNDRYBAL "
+ "WHERE ACCT_PRD = '"+ ls_acctprd +"' AND PRD_CODE = '"+ ls_closeprd +"' AND FIN_ENTITY = '"+ ls_finentity +"' " + "WHERE ACCT_PRD = ? AND PRD_CODE = ? AND FIN_ENTITY = ? "
+ "AND SITE_CODE = '"+ ls_sitecode +"' AND SUNDRY_TYPE = '"+ ls_sundrytype +"' AND SUNDRY_CODE = '"+ ls_sundrycode +"' " + "AND SITE_CODE = ? AND SUNDRY_TYPE = ? AND SUNDRY_CODE = ? "
+ "AND ACCT_CODE = '"+ ls_acctcode +"' AND CCTR_CODE = '"+ ls_cctrcode +"'"; + "AND ACCT_CODE = ? AND CCTR_CODE = ? ";
stmt = conn.createStatement(); // Added as stmt is closed and asigned null above - Piyush - 26/03/08 //stmt = conn.createStatement(); // Added as stmt is closed and asigned null above - Piyush - 26/03/08
rs = stmt.executeQuery(sql); //rs = stmt.executeQuery(sql);
pstmt= conn.prepareStatement(sql);
pstmt.setString(1, ls_acctprd);
pstmt.setString(2, ls_closeprd);
pstmt.setString(3, ls_finentity);
pstmt.setString(4, ls_sitecode);
pstmt.setString(5, ls_sundrytype);
pstmt.setString(6, ls_sundrycode);
pstmt.setString(7, ls_acctcode);
pstmt.setString(8, ls_cctrcode);
rs=pstmt.executeQuery();
if (rs.next()) if (rs.next())
{ {
ll_cnt = rs.getInt(1); ll_cnt = rs.getInt(1);
} }
stmt.close(); stmt = null;
rs.close(); rs = null; rs.close(); rs = null;
pstmt.close(); pstmt = null;
}//try }//try
catch(SQLException se) catch(SQLException se)
{ {
...@@ -1731,16 +1775,24 @@ public class FinCommon ...@@ -1731,16 +1775,24 @@ public class FinCommon
// insert if not found // insert if not found
try try
{ {
sql="SELECT COUNT(1) FROM ACCTBAL WHERE ACCT_PRD ='"+ls_acctprd+"' AND PRD_CODE ='"+ls_openprd+"' AND "+ sql="SELECT COUNT(1) FROM ACCTBAL WHERE ACCT_PRD ? AND PRD_CODE = ? AND "+
"FIN_ENTITY = '"+acctVar_finentity+"' AND SITE_CODE ='"+acctVar_sitecode+"' AND ACCT_CODE = '"+acctVar_acctcode+"' "+ "FIN_ENTITY = ? AND SITE_CODE = ? AND ACCT_CODE = ? "+
"AND CCTR_CODE ='"+acctVar_cctrcode+"'"; "AND CCTR_CODE = ? ";
rs = stmt.executeQuery(sql); //rs = stmt.executeQuery(sql);
pstmt=conn.prepareStatement(sql);
pstmt.setString(1, ls_acctprd);
pstmt.setString(2, ls_openprd);
pstmt.setString(3, acctVar_finentity);
pstmt.setString(4, acctVar_sitecode);
pstmt.setString(5, acctVar_acctcode);
pstmt.setString(6, acctVar_cctrcode);
rs=pstmt.executeQuery();
if (rs.next()) if (rs.next())
{ {
ll_cnt = rs.getInt(1); ll_cnt = rs.getInt(1);
} }
stmt.close(); stmt = null;
rs.close(); rs = null; rs.close(); rs = null;
pstmt.close(); pstmt = null;
if (ll_cnt == 0 ) if (ll_cnt == 0 )
{ {
try try
...@@ -1798,19 +1850,28 @@ public class FinCommon ...@@ -1798,19 +1850,28 @@ public class FinCommon
} }
try try
{ {
stmt = conn.createStatement(); //stmt = conn.createStatement();
// check for current period // check for current period
sql ="SELECT COUNT(1) FROM ACCTBAL WHERE ACCT_PRD = '"+ls_acctprd+"' AND PRD_CODE ='"+ls_prdcode+"' AND "+ sql ="SELECT COUNT(1) FROM ACCTBAL WHERE ACCT_PRD = ? AND PRD_CODE = ? AND "+
"FIN_ENTITY = '"+acctVar_finentity+"' AND SITE_CODE ='"+acctVar_sitecode+"' AND ACCT_CODE = '"+acctVar_acctcode+"' "+ "FIN_ENTITY = ? AND SITE_CODE = ? AND ACCT_CODE = ? "+
"AND CCTR_CODE ='"+acctVar_cctrcode+"'"; "AND CCTR_CODE = ? ";
rs = stmt.executeQuery(sql); //rs = stmt.executeQuery(sql);
pstmt = conn.prepareStatement(sql);
pstmt.setString(1, ls_acctprd);
pstmt.setString(2, ls_prdcode);
pstmt.setString(3, acctVar_finentity);
pstmt.setString(4, acctVar_sitecode);
pstmt.setString(5, acctVar_acctcode);
pstmt.setString(6, acctVar_cctrcode);
rs=pstmt.executeQuery();
if (rs.next()) if (rs.next())
{ {
ll_cnt = rs.getInt(1); ll_cnt = rs.getInt(1);
} }
stmt.close(); stmt = null;
rs.close(); rs = null; rs.close(); rs = null;
pstmt.close(); pstmt = null;
}//try }//try
catch(SQLException se) catch(SQLException se)
{ {
...@@ -1956,17 +2017,19 @@ public class FinCommon ...@@ -1956,17 +2017,19 @@ public class FinCommon
{ {
// check for closing balance // check for closing balance
//Added by Varsha V for closing resultset on 19-04-2018 //Added by Varsha V for closing resultset on 19-04-2018
stmt = conn.createStatement(); //stmt = conn.createStatement();
sql="SELECT COUNT(1) FROM ACCTBAL WHERE ACCT_PRD = '"+ls_acctprd+"'AND PRD_CODE ='"+ls_closeprd+"' AND "+ sql="SELECT COUNT(1) FROM ACCTBAL WHERE ACCT_PRD = '"+ls_acctprd+"'AND PRD_CODE ='"+ls_closeprd+"' AND "+
" FIN_ENTITY ='"+acctVar_finentity+"' AND SITE_CODE = '"+acctVar_sitecode+"' AND ACCT_CODE = '"+acctVar_acctcode+"' AND CCTR_CODE = '"+acctVar_cctrcode+"'"; " FIN_ENTITY ='"+acctVar_finentity+"' AND SITE_CODE = '"+acctVar_sitecode+"' AND ACCT_CODE = '"+acctVar_acctcode+"' AND CCTR_CODE = '"+acctVar_cctrcode+"'";
rs = stmt.executeQuery(sql); //rs = stmt.executeQuery(sql);
pstmt= conn.prepareStatement(sql);
rs=pstmt.executeQuery();
if (rs.next()) if (rs.next())
{ {
ll_cnt = rs.getInt(1); ll_cnt = rs.getInt(1);
} }
stmt.close(); stmt = null;
rs.close(); rs = null; rs.close(); rs = null;
pstmt.close(); pstmt = null;
}//try }//try
catch(SQLException se) catch(SQLException se)
{ {
...@@ -2189,12 +2252,18 @@ public class FinCommon ...@@ -2189,12 +2252,18 @@ public class FinCommon
String sql=""; String sql="";
ResultSet rs = null; ResultSet rs = null;
Statement stmt = null; Statement stmt = null;
PreparedStatement pstmt= null;
try try
{ {
System.out.println("In FINPARAMS......"); System.out.println("In FINPARAMS......");
stmt = conn.createStatement(); //stmt = conn.createStatement();
sql="SELECT VAR_VALUE FROM FINPARM WHERE PRD_CODE ='"+prdCode.trim()+"' AND VAR_NAME ='"+varName.trim()+"'"; sql="SELECT VAR_VALUE FROM FINPARM WHERE PRD_CODE = ? AND VAR_NAME = ? ";
rs =stmt.executeQuery(sql); //rs =stmt.executeQuery(sql);
pstmt=conn.prepareStatement(sql);
pstmt.setString(1, prdCode);
pstmt.setString(2, varName);
rs=pstmt.executeQuery();
if(rs.next()==false) if(rs.next()==false)
{ {
retVal = "NULLFOUND"; retVal = "NULLFOUND";
...@@ -2204,8 +2273,8 @@ public class FinCommon ...@@ -2204,8 +2273,8 @@ public class FinCommon
retVal =rs.getString(1); retVal =rs.getString(1);
} }
System.out.println("retval is " + retVal); System.out.println("retval is " + retVal);
stmt.close(); stmt = null;
rs.close(); rs = null; rs.close(); rs = null;
pstmt.close(); pstmt = null;
} }
catch(Exception e) catch(Exception e)
{ {
...@@ -2217,9 +2286,9 @@ public class FinCommon ...@@ -2217,9 +2286,9 @@ public class FinCommon
{ {
try try
{ {
if (stmt != null) if (pstmt != null)
{ {
stmt.close(); stmt = null; pstmt.close(); pstmt = null;
} }
if (rs != null) if (rs != null)
{ {
...@@ -2280,23 +2349,32 @@ public class FinCommon ...@@ -2280,23 +2349,32 @@ public class FinCommon
// commented by Nandkumar Gadkari on 17MAR2018 // commented by Nandkumar Gadkari on 17MAR2018
/*as_tran_date = genericUtility.getValidDateString(as_tran_date, genericUtility.getApplDateFormat(), genericUtility.getDBDateFormat()); /*as_tran_date = genericUtility.getValidDateString(as_tran_date, genericUtility.getApplDateFormat(), genericUtility.getDBDateFormat());
tranDate = java.sql.Timestamp.valueOf(as_tran_date + " 00:00:00");*/ tranDate = java.sql.Timestamp.valueOf(as_tran_date + " 00:00:00");*/
stmt = conn.createStatement(); //stmt = conn.createStatement();
sql = "SELECT FIN_ENTITY FROM SITE WHERE SITE_CODE ='"+as_login_site.trim()+"'"; sql = "SELECT FIN_ENTITY FROM SITE WHERE SITE_CODE = ?";
rs = stmt.executeQuery(sql); //rs = stmt.executeQuery(sql);
pstmt= conn.prepareStatement(sql);
pstmt.setString(1, as_login_site);
rs=pstmt.executeQuery();
if (rs.next()) if (rs.next())
{ {
ls_fin_entity = rs.getString(1); ls_fin_entity = rs.getString(1);
sql = "SELECT CURR_CODE FROM FINENT WHERE FIN_ENTITY = '"+ls_fin_entity.trim()+"'"; sql = "SELECT CURR_CODE FROM FINENT WHERE FIN_ENTITY = ?";
rs = stmt.executeQuery(sql); //rs = stmt.executeQuery(sql);
if (rs.next()) pstmt1= conn.prepareStatement(sql);
pstmt1.setString(1, ls_fin_entity);
rs1=pstmt1.executeQuery();
if (rs1.next())
{ {
ls_curr_code__to = rs.getString(1); ls_curr_code__to = rs1.getString(1);
} }
rs1.close(); rs1= null;
pstmt1.close(); pstmt1= null;
} }
//Modified by Anjali R. on[21/09/2018][Start] //Modified by Anjali R. on[21/09/2018][Start]
//stmt.close(); stmt = null; //stmt.close(); stmt = null;
rs.close(); rs = null; rs.close(); rs = null;
stmt.close(); stmt = null; pstmt.close(); pstmt = null;
//Modified by Anjali R. on[21/09/2018][End] //Modified by Anjali R. on[21/09/2018][End]
} }
catch(Exception e) catch(Exception e)
...@@ -2494,9 +2572,11 @@ public class FinCommon ...@@ -2494,9 +2572,11 @@ public class FinCommon
{ {
try try
{ {
stmt = conn.createStatement(); //stmt = conn.createStatement();
sql = "SELECT RTRIM(CASE WHEN VAR_VALUE IS NULL THEN 'Y' ELSE VAR_VALUE END) FROM FINPARM WHERE PRD_CODE = '999999' AND VAR_NAME = 'EXCRT_CURR'"; sql = "SELECT RTRIM(CASE WHEN VAR_VALUE IS NULL THEN 'Y' ELSE VAR_VALUE END) FROM FINPARM WHERE PRD_CODE = '999999' AND VAR_NAME = 'EXCRT_CURR'";
rs = stmt.executeQuery(sql); //rs = stmt.executeQuery(sql);
pstmt=conn.prepareStatement(sql);
rs=pstmt.executeQuery();
if (rs.next()) if (rs.next())
{ {
//Modified by Anjali R. on[21/09/2018][Start] //Modified by Anjali R. on[21/09/2018][Start]
...@@ -2515,6 +2595,11 @@ public class FinCommon ...@@ -2515,6 +2595,11 @@ public class FinCommon
rs.close(); rs.close();
rs = null; rs = null;
} }
if(pstmt!=null)
{
pstmt.close();
pstmt=null;
}
if(!"NULLFOUND".equalsIgnoreCase(var_value)) if(!"NULLFOUND".equalsIgnoreCase(var_value))
{ {
...@@ -2522,15 +2607,19 @@ public class FinCommon ...@@ -2522,15 +2607,19 @@ public class FinCommon
//Modified by Anjali R. on[21/09/2018][End] //Modified by Anjali R. on[21/09/2018][End]
if(var_value.equals("Y")) if(var_value.equals("Y"))
{ {
sql ="SELECT STD_EXRT FROM CURRENCY WHERE CURR_CODE = '"+as_curr_code.trim()+"'"; sql ="SELECT STD_EXRT FROM CURRENCY WHERE CURR_CODE = ? ";
System.out.println("Executing SQL ::"+sql); System.out.println("Executing SQL ::"+sql);
rs1 = stmt.executeQuery(sql); //rs1 = stmt.executeQuery(sql);
pstmt1=conn.prepareStatement(sql);
pstmt1.setString(1, as_curr_code.trim());
rs1=pstmt1.executeQuery();
if (rs1.next()) if (rs1.next())
{ {
lc_exch_rate = rs1.getDouble(1); lc_exch_rate = rs1.getDouble(1);
} }
// stmt.close(); stmt = null; // stmt.close(); stmt = null;
rs1.close(); rs1 = null; rs1.close(); rs1 = null;
pstmt1.close(); pstmt1=null;
} }
else else
{ {
...@@ -2545,17 +2634,26 @@ public class FinCommon ...@@ -2545,17 +2634,26 @@ public class FinCommon
rs1.close(); rs1.close();
rs1 = null; rs1 = null;
} }
if(pstmt1!=null)
{
pstmt1.close();
pstmt1=null;
}
//Modified by Anjali R. on[21/09/2018][End] //Modified by Anjali R. on[21/09/2018][End]
sql ="SELECT STD_EXRT FROM CURRENCY WHERE CURR_CODE = '"+as_curr_code.trim()+"'"; sql ="SELECT STD_EXRT FROM CURRENCY WHERE CURR_CODE = ?";
rs1 = stmt.executeQuery(sql); //rs1 = stmt.executeQuery(sql);
pstmt1 = conn.prepareStatement(sql);
pstmt1.setString(1, as_curr_code);
rs1=pstmt1.executeQuery();
if (rs1.next()) if (rs1.next())
{ {
lc_exch_rate = rs1.getDouble(1); lc_exch_rate = rs1.getDouble(1);
} }
// stmt.close(); stmt = null; // stmt.close(); stmt = null;
rs1.close(); rs1 = null; rs1.close(); rs1 = null;
pstmt1.close(); pstmt1=null;
} }
stmt.close(); stmt = null; //stmt.close(); stmt = null;
//rs.close(); rs = null;//Modified by Anjali R. on[21/09/2018] //rs.close(); rs = null;//Modified by Anjali R. on[21/09/2018]
} }
...@@ -2585,10 +2683,10 @@ public class FinCommon ...@@ -2585,10 +2683,10 @@ public class FinCommon
rs1.close(); rs1.close();
rs1 = null; rs1 = null;
} }
if(stmt != null) if(pstmt != null)
{ {
stmt.close(); pstmt.close();
stmt = null; pstmt = null;
} }
} }
catch(Exception e) catch(Exception e)
...@@ -2624,15 +2722,18 @@ public class FinCommon ...@@ -2624,15 +2722,18 @@ public class FinCommon
String errCode = "", siteSpec = ""; String errCode = "", siteSpec = "";
//long counter; //long counter;
String sql1 = ""; String sql1 = "";
Statement statement1 = null; //Statement statement1 = null;
ResultSet resultSet1 = null; ResultSet resultSet1 = null;
PreparedStatement pstmt1= null;
String sql2 = ""; String sql2 = "";
Statement stmt2 = null; //Statement stmt2 = null;
PreparedStatement pstmt2= null;
ResultSet resultSet2 = null; ResultSet resultSet2 = null;
String sql3 = ""; String sql3 = "";
Statement stmt3 = null; //Statement stmt3 = null;
PreparedStatement pstmt3= null;
ResultSet rs3 = null; ResultSet rs3 = null;
StringBuffer sql4 = null; StringBuffer sql4 = null;
...@@ -2649,20 +2750,28 @@ public class FinCommon ...@@ -2649,20 +2750,28 @@ public class FinCommon
} }
*/ */
sql1 = "SELECT VAR_VALUE FROM FINPARM WHERE PRD_CODE = '999999' AND VAR_NAME = 'SITE_SPECIFIC_ACCT'"; sql1 = "SELECT VAR_VALUE FROM FINPARM WHERE PRD_CODE = '999999' AND VAR_NAME = 'SITE_SPECIFIC_ACCT'";
statement1 = con.createStatement(); //statement1 = con.createStatement();
resultSet1 = statement1.executeQuery(sql1); //resultSet1 = statement1.executeQuery(sql1);
pstmt1= con.prepareStatement(sql1);
resultSet1=pstmt1.executeQuery();
if (resultSet1.next()) if (resultSet1.next())
{ {
sql2 = "SELECT COUNT(*) FROM ACCOUNTS WHERE ACCT_CODE = '" + acctCode + "'"; sql2 = "SELECT COUNT(*) FROM ACCOUNTS WHERE ACCT_CODE = ? ";
stmt2 = con.createStatement(); //stmt2 = con.createStatement();
resultSet2 = stmt2.executeQuery(sql2); //resultSet2 = stmt2.executeQuery(sql2);
pstmt2= con.prepareStatement(sql2);
pstmt2.setString(1, acctCode);
resultSet2=pstmt2.executeQuery();
if (resultSet2.next()) if (resultSet2.next())
{ {
if (resultSet2.getLong(1) != 0) if (resultSet2.getLong(1) != 0)
{ {
sql3 = "SELECT ACTIVE FROM ACCOUNTS WHERE ACCT_CODE = '" + acctCode + "'"; sql3 = "SELECT ACTIVE FROM ACCOUNTS WHERE ACCT_CODE = ?";
stmt3 = con.createStatement(); //stmt3 = con.createStatement();
rs3 = stmt3.executeQuery(sql3); //rs3 = stmt3.executeQuery(sql3);
pstmt3= con.prepareStatement(sql3);
pstmt3.setString(1, acctCode);
rs3=pstmt3.executeQuery();
if (rs3.next()) if (rs3.next())
{ {
if (!rs3.getString(1).equals("Y")) if (!rs3.getString(1).equals("Y"))
...@@ -2715,20 +2824,20 @@ public class FinCommon ...@@ -2715,20 +2824,20 @@ public class FinCommon
rs4.close(); //Rakesh rs4.close(); //Rakesh
} }
//Added by sarita on 15NOV2017 for open cursor issue[start] //Added by sarita on 15NOV2017 for open cursor issue[start]
if(statement1 != null) if(pstmt1 != null)
{ {
statement1.close(); pstmt1.close();
statement1 = null; pstmt1 = null;
} }
if(stmt2 != null) if(pstmt2 != null)
{ {
stmt2.close(); pstmt2.close();
stmt2 = null; pstmt2 = null;
} }
if(stmt3 != null) if(pstmt3 != null)
{ {
stmt3.close(); pstmt3.close();
stmt3 = null; pstmt3 = null;
} }
if(stmt4 != null) if(stmt4 != null)
{ {
...@@ -2786,6 +2895,7 @@ public class FinCommon ...@@ -2786,6 +2895,7 @@ public class FinCommon
long cnt = 0; long cnt = 0;
String sql = ""; String sql = "";
Statement stmt = null; Statement stmt = null;
PreparedStatement pstmt= null;
ResultSet rs = null; ResultSet rs = null;
String cctrCheck = null; String cctrCheck = null;
...@@ -2793,8 +2903,10 @@ public class FinCommon ...@@ -2793,8 +2903,10 @@ public class FinCommon
try try
{ {
sql = "SELECT VAR_VALUE FROM FINPARM WHERE PRD_CODE = '999999' AND VAR_NAME = 'CCTR_CHECK'"; sql = "SELECT VAR_VALUE FROM FINPARM WHERE PRD_CODE = '999999' AND VAR_NAME = 'CCTR_CHECK'";
stmt = con.createStatement(); //stmt = con.createStatement();
rs = stmt.executeQuery(sql); //rs = stmt.executeQuery(sql);
pstmt=con.prepareStatement(sql);
rs= pstmt.executeQuery();
if (rs.next()) if (rs.next())
{ {
cctrCheck = rs.getString(1); cctrCheck = rs.getString(1);
...@@ -2805,21 +2917,24 @@ public class FinCommon ...@@ -2805,21 +2917,24 @@ public class FinCommon
} }
rs.close(); rs.close();
rs = null; rs = null;
stmt.close(); pstmt.close();
stmt = null; pstmt = null;
if ("Y".equalsIgnoreCase(cctrCheck.trim() ) && cctrCode != null && cctrCode.trim().length() > 0 ) if ("Y".equalsIgnoreCase(cctrCheck.trim() ) && cctrCode != null && cctrCode.trim().length() > 0 )
{ {
sql = "SELECT COUNT(1) AS COUNTER FROM COSTCTR WHERE CCTR_CODE = '" + cctrCode + "'" ; sql = "SELECT COUNT(1) AS COUNTER FROM COSTCTR WHERE CCTR_CODE = ? " ;
stmt = con.createStatement(); //stmt = con.createStatement();
rs = stmt.executeQuery(sql); //rs = stmt.executeQuery(sql);
pstmt=con.prepareStatement(sql);
pstmt.setString(1, cctrCode);
rs= pstmt.executeQuery();
if (rs.next()) if (rs.next())
{ {
cnt = rs.getInt(1); cnt = rs.getInt(1);
} }
rs.close(); rs.close();
rs = null; rs = null;
stmt.close(); pstmt.close();
stmt = null; pstmt = null;
if (cnt == 0 ) if (cnt == 0 )
{ {
errCode = "VMCCTR1"; errCode = "VMCCTR1";
...@@ -2827,31 +2942,38 @@ public class FinCommon ...@@ -2827,31 +2942,38 @@ public class FinCommon
else else
{ {
// chandni // chandni
sql = "SELECT COUNT(1) FROM ACCOUNTS_CCTR WHERE ACCT_CODE = '" + acctCode + "' AND CCTR_CODE = '" + cctrCode + "'"; sql = "SELECT COUNT(1) FROM ACCOUNTS_CCTR WHERE ACCT_CODE = ? AND CCTR_CODE = ? ";
stmt = con.createStatement(); //stmt = con.createStatement();
rs = stmt.executeQuery(sql); //rs = stmt.executeQuery(sql);
pstmt=con.prepareStatement(sql);
pstmt.setString(1, acctCode);
pstmt.setString(2, cctrCode);
rs= pstmt.executeQuery();
if (rs.next()) if (rs.next())
{ {
cnt = rs.getInt(1); cnt = rs.getInt(1);
} }
rs.close(); rs.close();
rs = null; rs = null;
stmt.close(); pstmt.close();
stmt = null; pstmt = null;
if (cnt == 0) if (cnt == 0)
{ {
// chandni // chandni
sql = "SELECT COUNT(1) from ACCOUNTS_CCTR WHERE ACCT_CODE = '" + acctCode + "'"; sql = "SELECT COUNT(1) from ACCOUNTS_CCTR WHERE ACCT_CODE = ?";
stmt = con.createStatement(); //stmt = con.createStatement();
rs = stmt.executeQuery(sql); //rs = stmt.executeQuery(sql);
pstmt=con.prepareStatement(sql);
pstmt.setString(1, acctCode);
rs= pstmt.executeQuery();
if (rs.next()) if (rs.next())
{ {
cnt = rs.getInt(1); cnt = rs.getInt(1);
} }
rs.close(); rs.close();
rs = null; rs = null;
stmt.close(); pstmt.close();
stmt = null; pstmt = null;
if (cnt > 0) if (cnt > 0)
{ {
errCode = "VMCCTR2"; errCode = "VMCCTR2";
...@@ -11619,24 +11741,33 @@ public class FinCommon ...@@ -11619,24 +11741,33 @@ public class FinCommon
public String getProject(String refSer,String refId,Connection conn) throws ITMException//Added by Jiten public String getProject(String refSer,String refId,Connection conn) throws ITMException//Added by Jiten
{ {
Statement stmt = null; Statement stmt = null;
PreparedStatement pstmt = null;
ResultSet rs = null; ResultSet rs = null;
String sql = "",projectCode = ""; String sql = "",projectCode = "",tname="";
try{ try{
stmt = conn.createStatement(); //stmt = conn.createStatement();
if(refSer.equalsIgnoreCase("JOUR")){ if(refSer.equalsIgnoreCase("JOUR")){
sql = "select proj_code from journal where tran_id = '"+refId+"'"; sql = "select proj_code from journal where tran_id = '"+refId+"'";
tname = "journal";
} }
if(refSer.equalsIgnoreCase("E-PAY")){ if(refSer.equalsIgnoreCase("E-PAY")){
sql = "select proj_code from payment_exp where tran_id = '"+refId+"'"; //sql = "select proj_code from payment_exp where tran_id = '"+refId+"'";
tname = "payment_exp";
} }
if(refSer.equalsIgnoreCase("M-VOUC")){ if(refSer.equalsIgnoreCase("M-VOUC")){
sql = "select proj_code from misc_voucher where tran_id = '"+refId+"'"; //sql = "select proj_code from misc_voucher where tran_id = '"+refId+"'";
tname = "misc_voucher";
} }
if(refSer.equalsIgnoreCase("VOUCH")){ if(refSer.equalsIgnoreCase("VOUCH")){
sql = "select proj_code from voucher where tran_id = '"+refId+"'"; //sql = "select proj_code from voucher where tran_id = '"+refId+"'";
} tname = "voucher";
if(sql.trim().length() > 0){ }
rs = stmt.executeQuery(sql); if(tname.trim().length() > 0){
sql = "select proj_code from '"+tname+"' where tran_id = ? ";
//rs = stmt.executeQuery(sql);
pstmt=conn.prepareStatement(sql);
pstmt.setString(1, refId);
rs=pstmt.executeQuery();
if(rs.next()){ if(rs.next()){
projectCode = rs.getString(1); projectCode = rs.getString(1);
} }
...@@ -11650,10 +11781,10 @@ public class FinCommon ...@@ -11650,10 +11781,10 @@ public class FinCommon
rs.close(); rs.close();
rs = null; rs = null;
} }
if(stmt != null) if(pstmt != null)
{ {
stmt.close(); pstmt.close();
stmt = null; pstmt = null;
} }
}catch(Exception e){ }catch(Exception e){
...@@ -11754,7 +11885,9 @@ public class FinCommon ...@@ -11754,7 +11885,9 @@ public class FinCommon
} }
sql = "select ledg_post from accounts where acct_code = '"+glTran.get("acct_code").toString()+"'"; sql = "select ledg_post from accounts where acct_code = '"+glTran.get("acct_code").toString()+"'";
System.out.println("SQL :"+sql); System.out.println("SQL :"+sql);
rs = stmt.executeQuery(sql); pstmt=conn.prepareStatement(sql);
rs=pstmt.executeQuery();
//rs = stmt.executeQuery(sql);
if(rs.next()){ if(rs.next()){
ledgPost = rs.getString(1); ledgPost = rs.getString(1);
} }
...@@ -11764,6 +11897,11 @@ public class FinCommon ...@@ -11764,6 +11897,11 @@ public class FinCommon
rs.close(); rs.close();
rs = null; rs = null;
} }
if(pstmt !=null)
{
pstmt.close();
pstmt=null;
}
if(ledgPost == null){ if(ledgPost == null){
ledgPost = "D"; ledgPost = "D";
} }
...@@ -11775,11 +11913,14 @@ public class FinCommon ...@@ -11775,11 +11913,14 @@ public class FinCommon
sql = "select count(*) from gltran where prd_code = '"+glTran.get("prd_code").toString()+"' and site_code = '"+glTran.get("site_code").toString()+"' and " + sql = "select count(*) from gltran where prd_code = '"+glTran.get("prd_code").toString()+"' and site_code = '"+glTran.get("site_code").toString()+"' and " +
"acct_code = '"+glTran.get("acct_code").toString()+"' and cctr_code = '"+glTran.get("cctr_code").toString()+"' and tran_id__trace ='"+glTran.get("entry_batch_no").toString()+"'"; "acct_code = '"+glTran.get("acct_code").toString()+"' and cctr_code = '"+glTran.get("cctr_code").toString()+"' and tran_id__trace ='"+glTran.get("entry_batch_no").toString()+"'";
System.out.println("SQL :"+sql); System.out.println("SQL :"+sql);
rs = stmt.executeQuery(sql); // rs = stmt.executeQuery(sql);
pstmt=conn.prepareStatement(sql);
rs=pstmt.executeQuery();
if(rs.next()){ if(rs.next()){
cnt = rs.getInt(1); cnt = rs.getInt(1);
} }
rs.close(); rs.close(); rs=null;
pstmt.close(); pstmt=null;
if(cnt > 1){ if(cnt > 1){
errString = itmDBAccessEJB.getErrorString("","VTGLTRAN1","","",conn); errString = itmDBAccessEJB.getErrorString("","VTGLTRAN1","","",conn);
return errString; return errString;
...@@ -11842,11 +11983,15 @@ public class FinCommon ...@@ -11842,11 +11983,15 @@ public class FinCommon
sql = "select key_string from transetup where tran_window = 't_gltran'"; sql = "select key_string from transetup where tran_window = 't_gltran'";
System.out.println("SQL : "+sql); System.out.println("SQL : "+sql);
rs = stmt.executeQuery(sql); //rs = stmt.executeQuery(sql);
pstmt=conn.prepareStatement(sql);
rs=pstmt.executeQuery();
if(rs.next()){ if(rs.next()){
keyString = rs.getString(1); keyString = rs.getString(1);
} }
rs.close(); rs.close(); rs= null;
pstmt.close(); pstmt=null;
TransIDGenerator tg = new TransIDGenerator(xmlString, "SYSTEM", CommonConstants.DB_NAME); TransIDGenerator tg = new TransIDGenerator(xmlString, "SYSTEM", CommonConstants.DB_NAME);
glTranId = tg.generateTranSeqID("GLTRAN", "tran_id", keyString, conn); glTranId = tg.generateTranSeqID("GLTRAN", "tran_id", keyString, conn);
if(ledgPost.equals("S")){ if(ledgPost.equals("S")){
...@@ -11963,11 +12108,14 @@ public class FinCommon ...@@ -11963,11 +12108,14 @@ public class FinCommon
"and acct_code = '"+glTran.get("acct_code").toString()+"' and " + "and acct_code = '"+glTran.get("acct_code").toString()+"' and " +
"cctr_code = '"+glTran.get("cctr_code").toString()+"'"; "cctr_code = '"+glTran.get("cctr_code").toString()+"'";
System.out.println("SQL :"+sql); System.out.println("SQL :"+sql);
rs = stmt.executeQuery(sql); //rs = stmt.executeQuery(sql);
pstmt=conn.prepareStatement(sql);
rs=pstmt.executeQuery();
if(rs.next()){ if(rs.next()){
cnt = rs.getInt(1); cnt = rs.getInt(1);
} }
rs.close(); rs.close(); rs=null;
pstmt.close();pstmt=null;
if(cnt == 0){ if(cnt == 0){
try{ //added by poonam try{ //added by poonam
...@@ -12020,7 +12168,9 @@ public class FinCommon ...@@ -12020,7 +12168,9 @@ public class FinCommon
"and acct_code = '"+glTran.get("acct_code").toString()+"' " + "and acct_code = '"+glTran.get("acct_code").toString()+"' " +
"and cctr_code = '"+glTran.get("cctr_code").toString()+"'"; "and cctr_code = '"+glTran.get("cctr_code").toString()+"'";
System.out.println("SQL :"+sql); System.out.println("SQL :"+sql);
rs = stmt.executeQuery(sql); //rs = stmt.executeQuery(sql);
pstmt=conn.prepareStatement(sql);
rs=pstmt.executeQuery();
if(rs.next()){ if(rs.next()){
cnt = rs.getInt(1); cnt = rs.getInt(1);
} }
...@@ -12029,6 +12179,11 @@ public class FinCommon ...@@ -12029,6 +12179,11 @@ public class FinCommon
rs.close(); rs.close();
rs =null; rs =null;
} }
if(pstmt!=null)
{
pstmt.close();
pstmt=null;
}
if(cnt == 0){ if(cnt == 0){
try{ //Added by poonam try{ //Added by poonam
...@@ -12112,11 +12267,14 @@ public class FinCommon ...@@ -12112,11 +12267,14 @@ public class FinCommon
"and acct_code = '"+glTran.get("acct_code").toString()+"' " + "and acct_code = '"+glTran.get("acct_code").toString()+"' " +
"and cctr_code = '"+glTran.get("cctr_code").toString()+"'"; "and cctr_code = '"+glTran.get("cctr_code").toString()+"'";
System.out.println("SQL :"+sql); System.out.println("SQL :"+sql);
rs = stmt.executeQuery(sql); //rs = stmt.executeQuery(sql);
pstmt=conn.prepareStatement(sql);
rs=pstmt.executeQuery();
if(rs.next()){ if(rs.next()){
cnt = rs.getInt(1); cnt = rs.getInt(1);
} }
rs.close(); rs.close();rs=null;
pstmt.close(); pstmt=null;
if(cnt == 0){ if(cnt == 0){
try{ //added by poonam try{ //added by poonam
...@@ -12347,7 +12505,7 @@ public class FinCommon ...@@ -12347,7 +12505,7 @@ public class FinCommon
*/ */
public String updateBudget(String budgetXmlString,String warning,Connection conn) throws ITMException// Added by Jiten public String updateBudget(String budgetXmlString,String warning,Connection conn) throws ITMException// Added by Jiten
{ {
PreparedStatement pstmt= null; PreparedStatement pstmt= null,pstmt1 = null;
Statement stmt = null; Statement stmt = null;
ResultSet rs = null; ResultSet rs = null;
Document dom = null; Document dom = null;
...@@ -12544,7 +12702,10 @@ public class FinCommon ...@@ -12544,7 +12702,10 @@ public class FinCommon
"and cctr_code = '"+cctrCode+"' " + "and cctr_code = '"+cctrCode+"' " +
"and anal_code = '"+analCode+"'"; "and anal_code = '"+analCode+"'";
System.out.println("SQL :"+sql); System.out.println("SQL :"+sql);
updCnt = stmt.executeUpdate(sql); //updCnt = stmt.executeUpdate(sql);
pstmt1=conn.prepareStatement(sql);
updCnt=pstmt1.executeUpdate();
pstmt1.close();pstmt1=null;
} }
catch(SQLException se)//Added by poonam on 28-07-16 for exception handling:Start catch(SQLException se)//Added by poonam on 28-07-16 for exception handling:Start
{ {
...@@ -12572,7 +12733,10 @@ public class FinCommon ...@@ -12572,7 +12733,10 @@ public class FinCommon
"and cctr_code = '"+cctrCode+"' " + "and cctr_code = '"+cctrCode+"' " +
"and anal_code = '"+analCode+"'"; "and anal_code = '"+analCode+"'";
System.out.println("SQL :"+sql); System.out.println("SQL :"+sql);
updCnt = stmt.executeUpdate(sql); //updCnt = stmt.executeUpdate(sql);
pstmt1=conn.prepareStatement(sql);
updCnt=pstmt1.executeUpdate();
pstmt1.close();pstmt1=null;
} }
catch(SQLException se)//Added by poonam on 28-07-16 for exception handling:Start catch(SQLException se)//Added by poonam on 28-07-16 for exception handling:Start
{ {
...@@ -12596,7 +12760,10 @@ public class FinCommon ...@@ -12596,7 +12760,10 @@ public class FinCommon
"and cctr_code = '"+cctrCode+"' " + "and cctr_code = '"+cctrCode+"' " +
"and anal_code = '"+analCode+"'"; "and anal_code = '"+analCode+"'";
System.out.println("SQL :"+sql); System.out.println("SQL :"+sql);
updCnt = stmt.executeUpdate(sql); //updCnt = stmt.executeUpdate(sql);
pstmt1=conn.prepareStatement(sql);
updCnt=pstmt1.executeUpdate();
pstmt1.close();pstmt1=null;
} }
catch(SQLException se)//Added by poonam on 28-07-16 for exception handling:Start catch(SQLException se)//Added by poonam on 28-07-16 for exception handling:Start
{ {
...@@ -12691,7 +12858,10 @@ public class FinCommon ...@@ -12691,7 +12858,10 @@ public class FinCommon
"and cctr_code = '"+cctrCode+"' " + "and cctr_code = '"+cctrCode+"' " +
"and anal_code = '"+analCode+"'"; "and anal_code = '"+analCode+"'";
System.out.println("SQL :"+sql); System.out.println("SQL :"+sql);
updCount = stmt.executeUpdate(sql); //updCount = stmt.executeUpdate(sql);
pstmt1=conn.prepareStatement(sql);
updCount=pstmt1.executeUpdate();
pstmt1.close();pstmt1=null;
} }
catch(SQLException se)//Added by poonam on 28-07-16 for exception handling:Start catch(SQLException se)//Added by poonam on 28-07-16 for exception handling:Start
{ {
...@@ -12718,7 +12888,10 @@ public class FinCommon ...@@ -12718,7 +12888,10 @@ public class FinCommon
"and cctr_code = '"+cctrCode+"' " + "and cctr_code = '"+cctrCode+"' " +
"and anal_code = '"+analCode+"'"; "and anal_code = '"+analCode+"'";
System.out.println("SQL :"+sql); System.out.println("SQL :"+sql);
updCount = stmt.executeUpdate(sql); //updCount = stmt.executeUpdate(sql);
pstmt1=conn.prepareStatement(sql);
updCount=pstmt1.executeUpdate();
pstmt1.close();pstmt1=null;
} }
catch(SQLException se)//Added by poonam on 28-07-16 for exception handling:Start catch(SQLException se)//Added by poonam on 28-07-16 for exception handling:Start
{ {
...@@ -12742,7 +12915,10 @@ public class FinCommon ...@@ -12742,7 +12915,10 @@ public class FinCommon
"and cctr_code = '"+cctrCode+"' " + "and cctr_code = '"+cctrCode+"' " +
"and anal_code = '"+analCode+"'"; "and anal_code = '"+analCode+"'";
System.out.println("SQL :"+sql); System.out.println("SQL :"+sql);
updCount = stmt.executeUpdate(sql); //updCount = stmt.executeUpdate(sql);
pstmt1=conn.prepareStatement(sql);
updCount=pstmt1.executeUpdate();
pstmt1.close();pstmt1=null;
} }
catch(SQLException se)//Added by poonam on 28-07-16 for exception handling:Start catch(SQLException se)//Added by poonam on 28-07-16 for exception handling:Start
{ {
...@@ -13225,6 +13401,7 @@ public class FinCommon ...@@ -13225,6 +13401,7 @@ public class FinCommon
public String checkGlTranDrCrPreview(String refSer,String refId,Connection conn) throws ITMException //Added by Jiten public String checkGlTranDrCrPreview(String refSer,String refId,Connection conn) throws ITMException //Added by Jiten
{ {
Statement stmt = null; Statement stmt = null;
PreparedStatement pstmt = null;
ResultSet rs = null; ResultSet rs = null;
double drAmt = 0,crAmt = 0; double drAmt = 0,crAmt = 0;
double totDrAmt = 0,totCrAmt = 0,diffAmt = 0; double totDrAmt = 0,totCrAmt = 0,diffAmt = 0;
...@@ -13234,7 +13411,7 @@ public class FinCommon ...@@ -13234,7 +13411,7 @@ public class FinCommon
SimpleDateFormat sdf = null; SimpleDateFormat sdf = null;
HashMap glTran = null; HashMap glTran = null;
try{ try{
stmt = conn.createStatement(); //stmt = conn.createStatement();
// genericUtility = new GenericUtility(); // genericUtility = new GenericUtility();
itmDBAccessEJB = new ITMDBAccessEJB(); itmDBAccessEJB = new ITMDBAccessEJB();
sdf = new SimpleDateFormat(genericUtility.getApplDateFormat()); sdf = new SimpleDateFormat(genericUtility.getApplDateFormat());
...@@ -13242,7 +13419,9 @@ public class FinCommon ...@@ -13242,7 +13419,9 @@ public class FinCommon
"case when cr_amt is null then 0 else cr_amt end * exch_rate " + "case when cr_amt is null then 0 else cr_amt end * exch_rate " +
"from gltrace_preview where ref_ser = '"+refSer+"' and ref_id = '"+refId+"'"; "from gltrace_preview where ref_ser = '"+refSer+"' and ref_id = '"+refId+"'";
System.out.println("SQL :"+sql); System.out.println("SQL :"+sql);
rs = stmt.executeQuery(sql); //rs = stmt.executeQuery(sql);
pstmt= conn.prepareStatement(sql);
rs=pstmt.executeQuery();
while(rs.next()){ while(rs.next()){
drAmt = getRequiredDecimal(rs.getDouble(1), 2); drAmt = getRequiredDecimal(rs.getDouble(1), 2);
crAmt = getRequiredDecimal(rs.getDouble(2), 2); crAmt = getRequiredDecimal(rs.getDouble(2), 2);
...@@ -13253,7 +13432,8 @@ public class FinCommon ...@@ -13253,7 +13432,8 @@ public class FinCommon
totCrAmt = getRequiredDecimal(totCrAmt, 2); totCrAmt = getRequiredDecimal(totCrAmt, 2);
//System.out.println("debitAmt----"+drAmt+"--creditAmt---"+crAmt+"---Total Debit Amt---"+totDrAmt+"---Total Credit Amt---"+totCrAmt); //System.out.println("debitAmt----"+drAmt+"--creditAmt---"+crAmt+"---Total Debit Amt---"+totDrAmt+"---Total Credit Amt---"+totCrAmt);
} }
rs.close(); rs.close(); rs =null;
pstmt.close(); pstmt= null;
if(totDrAmt == totCrAmt){ if(totDrAmt == totCrAmt){
return ""; return "";
} }
...@@ -13352,10 +13532,10 @@ public class FinCommon ...@@ -13352,10 +13532,10 @@ public class FinCommon
rs.close(); rs.close();
rs=null; rs=null;
} }
if(stmt!=null) if(pstmt!=null)
{ {
stmt.close(); pstmt.close();
stmt=null; pstmt=null;
} }
} }
}catch(Exception e){ }catch(Exception e){
...@@ -13365,7 +13545,7 @@ public class FinCommon ...@@ -13365,7 +13545,7 @@ public class FinCommon
}finally{ }finally{
try{ try{
if(rs != null){rs.close();rs = null;} if(rs != null){rs.close();rs = null;}
if(stmt != null){stmt.close();stmt = null;} if(pstmt != null){pstmt.close();pstmt = null;}
}catch(Exception t){} }catch(Exception t){}
} }
System.out.println("checkGlTranDrCrPreview errString :"+errString); System.out.println("checkGlTranDrCrPreview errString :"+errString);
...@@ -13464,14 +13644,16 @@ public class FinCommon ...@@ -13464,14 +13644,16 @@ public class FinCommon
sqlTemp = "SELECT A.CURR_CODE FROM FINENT A, SITE B WHERE B.FIN_ENTITY = A.FIN_ENTITY " sqlTemp = "SELECT A.CURR_CODE FROM FINENT A, SITE B WHERE B.FIN_ENTITY = A.FIN_ENTITY "
+" AND B.SITE_CODE = '"+ siteCode +"' "; +" AND B.SITE_CODE = '"+ siteCode +"' ";
System.out.println("SQL for FINENT,SITE :: "+sqlTemp); System.out.println("SQL for FINENT,SITE :: "+sqlTemp);
stmtTemp = conn.createStatement(); //stmtTemp = conn.createStatement();
rsTemp = stmtTemp.executeQuery(sqlTemp); //rsTemp = stmtTemp.executeQuery(sqlTemp);
pstmt = conn.prepareStatement(sqlTemp);
rsTemp = pstmt.executeQuery();
if (rsTemp.next()) if (rsTemp.next())
{ {
currCode = rsTemp.getString("CURR_CODE"); currCode = rsTemp.getString("CURR_CODE");
} }
rsTemp.close(); rsTemp.close(); rsTemp = null;
stmtTemp.close(); pstmt.close(); pstmt = null;
} }
...@@ -13496,14 +13678,16 @@ public class FinCommon ...@@ -13496,14 +13678,16 @@ public class FinCommon
+" BANK_CODE = '"+ bankCode +"' AND TRAN_TYPE = 'P' AND " +" BANK_CODE = '"+ bankCode +"' AND TRAN_TYPE = 'P' AND "
+" TRAN_SER <> 'R-DIS' AND REF_NO = '"+ refNo +"' "; +" TRAN_SER <> 'R-DIS' AND REF_NO = '"+ refNo +"' ";
System.out.println("SQL for banktranlog :: "+sqlTemp); System.out.println("SQL for banktranlog :: "+sqlTemp);
stmtTemp = conn.createStatement(); //stmtTemp = conn.createStatement();
rsTemp = stmtTemp.executeQuery(sqlTemp); //rsTemp = stmtTemp.executeQuery(sqlTemp);
pstmt = conn.prepareStatement(sqlTemp);
rsTemp = pstmt.executeQuery();
if (rsTemp.next()) if (rsTemp.next())
{ {
bankCntr = rsTemp.getInt("COUNTER"); bankCntr = rsTemp.getInt("COUNTER");
} }
rsTemp.close(); rsTemp.close(); rsTemp = null;
stmtTemp.close(); pstmt.close(); pstmt = null;
if (bankCntr > 0) if (bankCntr > 0)
{ {
...@@ -13516,8 +13700,10 @@ public class FinCommon ...@@ -13516,8 +13700,10 @@ public class FinCommon
} }
sqlTemp = "SELECT KEY_STRING FROM TRANSETUP WHERE UPPER(TRAN_WINDOW) = 'T_BANKTRAN_LOG' "; sqlTemp = "SELECT KEY_STRING FROM TRANSETUP WHERE UPPER(TRAN_WINDOW) = 'T_BANKTRAN_LOG' ";
System.out.println("SQL for Transetup :: "+sqlTemp); System.out.println("SQL for Transetup :: "+sqlTemp);
stmtTemp = conn.createStatement(); //stmtTemp = conn.createStatement();
rsTemp = stmtTemp.executeQuery(sqlTemp); //rsTemp = stmtTemp.executeQuery(sqlTemp);
pstmt = conn.prepareStatement(sqlTemp);
rsTemp = pstmt.executeQuery();
if (rsTemp.next()) if (rsTemp.next())
{ {
keyString = rsTemp.getString("KEY_STRING"); keyString = rsTemp.getString("KEY_STRING");
...@@ -13529,8 +13715,8 @@ public class FinCommon ...@@ -13529,8 +13715,8 @@ public class FinCommon
errString = itmDBAccessEJB.getErrorString("TRAN_ID",errCode,chgUser,"",conn); errString = itmDBAccessEJB.getErrorString("TRAN_ID",errCode,chgUser,"",conn);
break; break;
} }
rsTemp.close(); rsTemp.close(); rsTemp = null;
stmtTemp.close(); pstmt.close(); pstmt = null;
TransIDGenerator tg = new TransIDGenerator(valueXml.toString(), chgUser, CommonConstants.DB_NAME); TransIDGenerator tg = new TransIDGenerator(valueXml.toString(), chgUser, CommonConstants.DB_NAME);
newTranId = tg.generateTranSeqID("BK-LOG", "tran_id", keyString, conn); newTranId = tg.generateTranSeqID("BK-LOG", "tran_id", keyString, conn);
...@@ -13546,15 +13732,17 @@ public class FinCommon ...@@ -13546,15 +13732,17 @@ public class FinCommon
sqlTemp = "SELECT ROUND, ROUND_TO FROM CURRENCY WHERE CURR_CODE = '"+ currCode +"' "; sqlTemp = "SELECT ROUND, ROUND_TO FROM CURRENCY WHERE CURR_CODE = '"+ currCode +"' ";
System.out.println("SQL for Currency :: "+sqlTemp); System.out.println("SQL for Currency :: "+sqlTemp);
stmtTemp = conn.createStatement(); //stmtTemp = conn.createStatement();
rsTemp = stmtTemp.executeQuery(sqlTemp); //rsTemp = stmtTemp.executeQuery(sqlTemp);
pstmt = conn.prepareStatement(sqlTemp);
rsTemp = pstmt.executeQuery();
if (rsTemp.next()) if (rsTemp.next())
{ {
rndTo = rsTemp.getDouble("ROUND_TO"); rndTo = rsTemp.getDouble("ROUND_TO");
rndOff = rsTemp.getString("ROUND"); rndOff = rsTemp.getString("ROUND");
} }
rsTemp.close(); rsTemp.close(); rsTemp = null;
stmtTemp.close(); pstmt.close(); pstmt = null;
//amountBc = gf_get_rndamt(lc_amount_bc, ls_rndto, lc_rndoff) //amountBc = gf_get_rndamt(lc_amount_bc, ls_rndto, lc_rndoff)
try{ //poonam try{ //poonam
...@@ -15296,8 +15484,10 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15296,8 +15484,10 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
if (modCode.equals("ADM")) //$NON-NLS-1$ if (modCode.equals("ADM")) //$NON-NLS-1$
{ {
sql = "SELECT STAT_ADM,PROC_DATE FROM PERIOD_STAT WHERE SITE_CODE = '" + siteCode + "' AND PRD_CODE = '" + prdCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ sql = "SELECT STAT_ADM,PROC_DATE FROM PERIOD_STAT WHERE SITE_CODE = '" + siteCode + "' AND PRD_CODE = '" + prdCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
stmtPeriod = conn.createStatement(); //stmtPeriod = conn.createStatement();
rsPeriod = stmtPeriod.executeQuery(sql); //rsPeriod = stmtPeriod.executeQuery(sql);
pstmt = conn.prepareStatement(sql);
rsPeriod=pstmt.executeQuery();
if(rsPeriod.next()) if(rsPeriod.next())
{ {
stat = rsPeriod.getString(1); stat = rsPeriod.getString(1);
...@@ -15322,12 +15512,19 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15322,12 +15512,19 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
rsPeriod.close(); rsPeriod.close();
rsPeriod = null; rsPeriod = null;
} }
if(pstmt != null)
{
pstmt.close();
pstmt = null;
}
} }
else if (modCode.equals("FIN")) //$NON-NLS-1$ else if (modCode.equals("FIN")) //$NON-NLS-1$
{ {
sql = "SELECT STAT_FIN,PROC_DATE FROM PERIOD_STAT WHERE SITE_CODE = '" + siteCode + "' AND PRD_CODE = '" + prdCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ sql = "SELECT STAT_FIN,PROC_DATE FROM PERIOD_STAT WHERE SITE_CODE = '" + siteCode + "' AND PRD_CODE = '" + prdCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
stmtPeriod = conn.createStatement(); //stmtPeriod = conn.createStatement();
rsPeriod =stmtPeriod.executeQuery(sql); //rsPeriod =stmtPeriod.executeQuery(sql);
pstmt = conn.prepareStatement(sql);
rsPeriod=pstmt.executeQuery();
if(rsPeriod.next()) if(rsPeriod.next())
{ {
stat = rsPeriod.getString(1); stat = rsPeriod.getString(1);
...@@ -15352,12 +15549,17 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15352,12 +15549,17 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
rsPeriod.close(); rsPeriod.close();
rsPeriod = null; rsPeriod = null;
} }
if(pstmt != null)
{
pstmt.close();
pstmt = null;
}
} }
else if (modCode.equals("PUR")) //$NON-NLS-1$ else if (modCode.equals("PUR")) //$NON-NLS-1$
{ {
sql = "SELECT STAT_PUR,PROC_DATE FROM PERIOD_STAT WHERE SITE_CODE = '" + siteCode + "' AND PRD_CODE = '" + prdCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ sql = "SELECT STAT_PUR,PROC_DATE FROM PERIOD_STAT WHERE SITE_CODE = '" + siteCode + "' AND PRD_CODE = '" + prdCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
stmtPeriod = conn.createStatement(); pstmt = conn.prepareStatement(sql);
rsPeriod = stmtPeriod.executeQuery(sql); rsPeriod=pstmt.executeQuery();
if(rsPeriod.next()) if(rsPeriod.next())
{ {
stat = rsPeriod.getString(1); stat = rsPeriod.getString(1);
...@@ -15382,12 +15584,19 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15382,12 +15584,19 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
rsPeriod.close(); rsPeriod.close();
rsPeriod = null; rsPeriod = null;
} }
if(pstmt != null)
{
pstmt.close();
pstmt = null;
}
} }
else if (modCode.equals("SAL")) //$NON-NLS-1$ else if (modCode.equals("SAL")) //$NON-NLS-1$
{ {
sql = "SELECT STAT_SAL,PROC_DATE FROM PERIOD_STAT WHERE SITE_CODE = '" + siteCode + "' AND PRD_CODE = '" + prdCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ sql = "SELECT STAT_SAL,PROC_DATE FROM PERIOD_STAT WHERE SITE_CODE = '" + siteCode + "' AND PRD_CODE = '" + prdCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
stmtPeriod = conn.createStatement(); //stmtPeriod = conn.createStatement();
rsPeriod = stmtPeriod.executeQuery(sql); //rsPeriod = stmtPeriod.executeQuery(sql);
pstmt = conn.prepareStatement(sql);
rsPeriod=pstmt.executeQuery();
if(rsPeriod.next()) if(rsPeriod.next())
{ {
stat = rsPeriod.getString(1); stat = rsPeriod.getString(1);
...@@ -15412,12 +15621,19 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15412,12 +15621,19 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
rsPeriod.close(); rsPeriod.close();
rsPeriod = null; rsPeriod = null;
} }
if(pstmt != null)
{
pstmt.close();
pstmt = null;
}
} }
else if (modCode.equals("MFG")) //$NON-NLS-1$ else if (modCode.equals("MFG")) //$NON-NLS-1$
{ {
sql = "SELECT STAT_MFG,PROC_DATE FROM PERIOD_STAT WHERE SITE_CODE = '" + siteCode + "' AND PRD_CODE = '" + prdCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ sql = "SELECT STAT_MFG,PROC_DATE FROM PERIOD_STAT WHERE SITE_CODE = '" + siteCode + "' AND PRD_CODE = '" + prdCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
stmtPeriod = conn.createStatement(); //stmtPeriod = conn.createStatement();
rsPeriod = stmtPeriod.executeQuery(sql); //rsPeriod = stmtPeriod.executeQuery(sql);
pstmt = conn.prepareStatement(sql);
rsPeriod=pstmt.executeQuery();
if(rsPeriod.next()) if(rsPeriod.next())
{ {
stat = rsPeriod.getString(1); stat = rsPeriod.getString(1);
...@@ -15442,12 +15658,19 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15442,12 +15658,19 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
rsPeriod.close(); rsPeriod.close();
rsPeriod = null; rsPeriod = null;
} }
if(pstmt != null)
{
pstmt.close();
pstmt = null;
}
} }
else if (modCode.equals("IC") || modCode.equals("DIS")) //$NON-NLS-1$ //$NON-NLS-2$ else if (modCode.equals("IC") || modCode.equals("DIS")) //$NON-NLS-1$ //$NON-NLS-2$
{ {
sql = "SELECT STAT_IC,PROC_DATE FROM PERIOD_STAT WHERE SITE_CODE = '" + siteCode + "' AND PRD_CODE = '" + prdCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ sql = "SELECT STAT_IC,PROC_DATE FROM PERIOD_STAT WHERE SITE_CODE = '" + siteCode + "' AND PRD_CODE = '" + prdCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
stmtPeriod = conn.createStatement(); //stmtPeriod = conn.createStatement();
rsPeriod = stmtPeriod.executeQuery(sql); //rsPeriod = stmtPeriod.executeQuery(sql);
pstmt = conn.prepareStatement(sql);
rsPeriod=pstmt.executeQuery();
if(rsPeriod.next()) if(rsPeriod.next())
{ {
stat = rsPeriod.getString(1); stat = rsPeriod.getString(1);
...@@ -15472,13 +15695,20 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15472,13 +15695,20 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
rsPeriod.close(); rsPeriod.close();
rsPeriod = null; rsPeriod = null;
} }
if(pstmt != null)
{
pstmt.close();
pstmt = null;
}
} }
else if (modCode.equals("HLT")) //$NON-NLS-1$ else if (modCode.equals("HLT")) //$NON-NLS-1$
{ {
sql = "SELECT STAT_HLT,PROC_DATE FROM PERIOD_STAT WHERE SITE_CODE = '" + siteCode + "' AND PRD_CODE = '" + prdCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ sql = "SELECT STAT_HLT,PROC_DATE FROM PERIOD_STAT WHERE SITE_CODE = '" + siteCode + "' AND PRD_CODE = '" + prdCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
// System.out.println("Executing Query ::"+sql); // System.out.println("Executing Query ::"+sql);
stmtPeriod = conn.createStatement(); //stmtPeriod = conn.createStatement();
rsPeriod = stmtPeriod.executeQuery(sql); //rsPeriod = stmtPeriod.executeQuery(sql);
pstmt = conn.prepareStatement(sql);
rsPeriod=pstmt.executeQuery();
if(rsPeriod.next()) if(rsPeriod.next())
{ {
stat = rsPeriod.getString(1); stat = rsPeriod.getString(1);
...@@ -15503,6 +15733,11 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15503,6 +15733,11 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
rsPeriod.close(); rsPeriod.close();
rsPeriod = null; rsPeriod = null;
} }
if(pstmt != null)
{
pstmt.close();
pstmt = null;
}
} }
if(stmtPeriod != null) if(stmtPeriod != null)
{ {
...@@ -15574,6 +15809,10 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15574,6 +15809,10 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
Statement stmt1 = null; Statement stmt1 = null;
Statement stmt2 = null; Statement stmt2 = null;
Statement stmt3 = null; Statement stmt3 = null;
PreparedStatement pstmt1= null;
PreparedStatement pstmt2= null;
PreparedStatement pstmt3= null;
ResultSet rs1 = null; ResultSet rs1 = null;
ResultSet rs2 = null; ResultSet rs2 = null;
ResultSet rs3 = null; ResultSet rs3 = null;
...@@ -15583,8 +15822,10 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15583,8 +15822,10 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
{ {
//con = getConnection(); //con = getConnection();
sql1 = "SELECT COUNT(1) FROM BANK WHERE BANK_CODE = '" + bankCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$ sql1 = "SELECT COUNT(1) FROM BANK WHERE BANK_CODE = '" + bankCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$
stmt1 = con.createStatement(); //stmt1 = con.createStatement();
rs1 = stmt1.executeQuery(sql1); //rs1 = stmt1.executeQuery(sql1);'
pstmt1 = con.prepareStatement(sql1);
rs1= pstmt1.executeQuery();
if (rs1.next()) if (rs1.next())
{ {
counter = rs1.getLong(1); counter = rs1.getLong(1);
...@@ -15596,20 +15837,24 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15596,20 +15837,24 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
else else
{ {
sql1 = "SELECT SITE_CODE FROM BANK WHERE BANK_CODE = '" + bankCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$ sql1 = "SELECT SITE_CODE FROM BANK WHERE BANK_CODE = '" + bankCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$
stmt2 = con.createStatement(); //stmt2 = con.createStatement();
//Added by sarita on 17NOV2017, for open cursor issue //Added by sarita on 17NOV2017, for open cursor issue
//rs2 = stmt1.executeQuery(sql1); //rs2 = stmt1.executeQuery(sql1);
rs2 = stmt2.executeQuery(sql1); //rs2 = stmt2.executeQuery(sql1);
pstmt2 = con.prepareStatement(sql1);
rs2 = pstmt2.executeQuery();
if(rs2.next()) if(rs2.next())
{ {
colValue = rs2.getString(1); colValue = rs2.getString(1);
if (!colValue.trim().equals(siteCode)) if (!colValue.trim().equals(siteCode))
{ {
sql1 = "SELECT COUNT(1) FROM SITE_BANK WHERE SITE_CODE ='" + siteCode + "' AND BANK_CODE = '" + bankCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ sql1 = "SELECT COUNT(1) FROM SITE_BANK WHERE SITE_CODE ='" + siteCode + "' AND BANK_CODE = '" + bankCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
stmt3 = con.createStatement(); //stmt3 = con.createStatement();
//Added by sarita on 17NOV2017, for open cursor issue //Added by sarita on 17NOV2017, for open cursor issue
//rs3 = stmt1.executeQuery(sql1); //rs3 = stmt1.executeQuery(sql1);
rs3 = stmt3.executeQuery(sql1); // rs3 = stmt3.executeQuery(sql1);
pstmt3 = con.prepareStatement(sql1);
rs3 = pstmt3.executeQuery();
if (rs3.next()) if (rs3.next())
{ {
counter = rs3.getLong(1); counter = rs3.getLong(1);
...@@ -15645,20 +15890,20 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15645,20 +15890,20 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
rs3.close(); rs3.close();
rs3 = null; rs3 = null;
} }
if(stmt1 != null) if(pstmt1 != null)
{ {
stmt1.close(); pstmt1.close();
stmt1 = null; pstmt1 = null;
} }
if(stmt2 != null) if(pstmt2 != null)
{ {
stmt2.close(); pstmt2.close();
stmt2 = null; pstmt2 = null;
} }
if(stmt3 != null) if(pstmt3 != null)
{ {
stmt3.close(); pstmt3.close();
stmt3 = null; pstmt3 = null;
} }
//Added by sarita on 17NOV2017, for open cursor issue [end] //Added by sarita on 17NOV2017, for open cursor issue [end]
} }
...@@ -15678,14 +15923,17 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15678,14 +15923,17 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
String sql1 = ""; //$NON-NLS-1$ String sql1 = ""; //$NON-NLS-1$
//Connection con = null; //Connection con = null;
Statement stmt1 = null; Statement stmt1 = null;
PreparedStatement pstmt1 = null;
ResultSet rs1 = null; ResultSet rs1 = null;
try try
{ {
//con = getConnection(); //con = getConnection();
sql1 = "SELECT COUNT(1) FROM SITE WHERE SITE_CODE = '" + siteCode + "'" ; //$NON-NLS-1$ //$NON-NLS-2$ sql1 = "SELECT COUNT(1) FROM SITE WHERE SITE_CODE = '" + siteCode + "'" ; //$NON-NLS-1$ //$NON-NLS-2$
stmt1 = con.createStatement(); //stmt1 = con.createStatement();
rs1 = stmt1.executeQuery(sql1); //rs1 = stmt1.executeQuery(sql1);
pstmt1 = con.prepareStatement(sql1);
rs1 = pstmt1.executeQuery();
if (rs1.next()) if (rs1.next())
{ {
counter = rs1.getLong(1); counter = rs1.getLong(1);
...@@ -15694,8 +15942,8 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15694,8 +15942,8 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
errCode = "VMSITE1"; //$NON-NLS-1$ errCode = "VMSITE1"; //$NON-NLS-1$
} }
} }
rs1.close(); rs1.close(); rs1 = null;
stmt1.close(); pstmt1.close(); pstmt1 = null;
//con.close(); //con.close();
} }
catch(Exception e) catch(Exception e)
...@@ -15714,13 +15962,16 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15714,13 +15962,16 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
String sql1 = ""; //$NON-NLS-1$ String sql1 = ""; //$NON-NLS-1$
//Connection con = null; //Connection con = null;
Statement stmt1 = null; Statement stmt1 = null;
PreparedStatement pstmt =null;
ResultSet rs1 = null; ResultSet rs1 = null;
try try
{ {
//con = getConnection(); //con = getConnection();
sql1 = "SELECT COUNT(1) FROM FINENT WHERE FIN_ENTITY = '" + finEntity + "'" ; //$NON-NLS-1$ //$NON-NLS-2$ sql1 = "SELECT COUNT(1) FROM FINENT WHERE FIN_ENTITY = '" + finEntity + "'" ; //$NON-NLS-1$ //$NON-NLS-2$
stmt1 = con.createStatement(); //stmt1 = con.createStatement();
rs1 = stmt1.executeQuery(sql1); //rs1 = stmt1.executeQuery(sql1);
pstmt = con.prepareStatement(sql1);
rs1 = pstmt.executeQuery();
if (rs1.next()) if (rs1.next())
{ {
counter = rs1.getLong(1); counter = rs1.getLong(1);
...@@ -15731,8 +15982,8 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15731,8 +15982,8 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
} }
// rs1.close(); // rs1.close();
//Added by Varsha V for closing resultset on 19-04-2018 //Added by Varsha V for closing resultset on 19-04-2018
rs1.close(); rs1.close(); rs1.close();
stmt1.close(); pstmt.close(); pstmt.close();
//con.close(); //con.close();
} }
catch(Exception e) catch(Exception e)
...@@ -15751,21 +16002,27 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15751,21 +16002,27 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
String blackList = ""; //$NON-NLS-1$ String blackList = ""; //$NON-NLS-1$
String sql21 = ""; //$NON-NLS-1$ String sql21 = ""; //$NON-NLS-1$
Statement stmt21 = null; Statement stmt21 = null;
PreparedStatement pstmt21 = null;
ResultSet rs21 =null; ResultSet rs21 =null;
StringBuffer sql22 = null; StringBuffer sql22 = null;
Statement stmt22 = null; Statement stmt22 = null;
PreparedStatement pstmt22 = null;
ResultSet rs22 =null; ResultSet rs22 =null;
String sql23 = ""; //$NON-NLS-1$ String sql23 = ""; //$NON-NLS-1$
Statement stmt23 = null; Statement stmt23 = null;
PreparedStatement pstmt23 = null;
ResultSet rs23 =null; ResultSet rs23 =null;
String sql24 = ""; //$NON-NLS-1$ String sql24 = ""; //$NON-NLS-1$
Statement stmt24 = null; Statement stmt24 = null;
PreparedStatement pstmt24 = null;
ResultSet rs24 =null; ResultSet rs24 =null;
try try
{ {
sql21 = "SELECT VAR_VALUE FROM DISPARM WHERE PRD_CODE = '999999' AND VAR_NAME = 'SITE_SPECIFIC_CUST'"; //$NON-NLS-1$ sql21 = "SELECT VAR_VALUE FROM DISPARM WHERE PRD_CODE = '999999' AND VAR_NAME = 'SITE_SPECIFIC_CUST'"; //$NON-NLS-1$
stmt21 = conn.createStatement(); //stmt21 = conn.createStatement();
rs21 = stmt21.executeQuery(sql21); //rs21 = stmt21.executeQuery(sql21);
pstmt21= conn.prepareStatement(sql21);
rs21= pstmt21.executeQuery();
if (rs21.next()) if (rs21.next())
{ {
//Commented and Changes done by Gaurav Singh on 07-Sep-2015 to check null for avoiding nullPointerException [ Start ] //Commented and Changes done by Gaurav Singh on 07-Sep-2015 to check null for avoiding nullPointerException [ Start ]
...@@ -15777,8 +16034,11 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15777,8 +16034,11 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
sql22.append("SELECT ACTIVE_YN FROM SITE_CUSTOMER "); //$NON-NLS-1$ sql22.append("SELECT ACTIVE_YN FROM SITE_CUSTOMER "); //$NON-NLS-1$
sql22.append("WHERE SITE_CODE = '").append(siteCode); //$NON-NLS-1$ sql22.append("WHERE SITE_CODE = '").append(siteCode); //$NON-NLS-1$
sql22.append("' AND CUST_CODE = '").append(custCode).append("'"); //$NON-NLS-1$ //$NON-NLS-2$ sql22.append("' AND CUST_CODE = '").append(custCode).append("'"); //$NON-NLS-1$ //$NON-NLS-2$
stmt22 = conn.createStatement(); //stmt22 = conn.createStatement();
rs22 = stmt22.executeQuery(sql22.toString()); //rs22 = stmt22.executeQuery(sql22.toString());
pstmt22 = conn.prepareStatement(sql22.toString());
rs22 = pstmt22.executeQuery();
if (rs22.next()) if (rs22.next())
{ {
active = (rs22.getString(1) == null)?"":rs22.getString(1).trim(); active = (rs22.getString(1) == null)?"":rs22.getString(1).trim();
...@@ -15803,15 +16063,17 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15803,15 +16063,17 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
{ {
errCode = "VTCUSTCD2"; //$NON-NLS-1$ errCode = "VTCUSTCD2"; //$NON-NLS-1$
} }
rs22.close(); rs22.close(); rs22 = null;
stmt22.close(); pstmt22.close(); pstmt22 = null;
} }
} }
rs21.close(); rs21.close(); rs21 = null;
stmt21.close(); pstmt21.close(); pstmt21 = null;
sql23 = "SELECT CASE WHEN COUNT(1) IS NULL THEN 0 ELSE COUNT(1) END FROM CUSTOMER WHERE CUST_CODE = '" + custCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$ sql23 = "SELECT CASE WHEN COUNT(1) IS NULL THEN 0 ELSE COUNT(1) END FROM CUSTOMER WHERE CUST_CODE = '" + custCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$
stmt23 = conn.createStatement(); //stmt23 = conn.createStatement();
rs23 = stmt23.executeQuery(sql23); //rs23 = stmt23.executeQuery(sql23);
pstmt23 = conn.prepareStatement(sql23);
rs23= pstmt23.executeQuery();
if (rs23.next()) if (rs23.next())
{ {
if (rs23.getInt(1) == 0) if (rs23.getInt(1) == 0)
...@@ -15820,12 +16082,14 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15820,12 +16082,14 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
} }
} }
rs23.close(); rs23.close();
stmt23.close(); pstmt23.close();
if (errCode == null || errCode.length() == 0) if (errCode == null || errCode.length() == 0)
{ {
sql24 = "SELECT BLACK_LISTED FROM CUSTOMER WHERE CUST_CODE = '" + custCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$ sql24 = "SELECT BLACK_LISTED FROM CUSTOMER WHERE CUST_CODE = '" + custCode + "'"; //$NON-NLS-1$ //$NON-NLS-2$
stmt24 = conn.createStatement(); //stmt24 = conn.createStatement();
rs24 = stmt24.executeQuery(sql24); //rs24 = stmt24.executeQuery(sql24);
pstmt24 = conn.prepareStatement(sql24);
rs24 = pstmt24.executeQuery();
if (rs24.next()) if (rs24.next())
{ {
blackList = rs24.getString(1); blackList = rs24.getString(1);
...@@ -15848,8 +16112,8 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit ...@@ -15848,8 +16112,8 @@ public String nfCheckPeriod(String modCode, java.util.Date tranDate , String sit
else else
errCode = "VTCUSTCD3"; //$NON-NLS-1$ errCode = "VTCUSTCD3"; //$NON-NLS-1$
} }
rs24.close(); rs24.close(); rs24 = null;
stmt24.close(); pstmt24.close(); pstmt24 = null;
//Commented and Changes done by Gaurav Singh on 07-Sep-2015 to check null for avoiding nullPointerException [ End ] //Commented and Changes done by Gaurav Singh on 07-Sep-2015 to check null for avoiding nullPointerException [ End ]
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment