@ Sandesh : Confirmed query enhanced.Confirmed check for multiple records

                         added. Prepared statements used instead of statements.
                         Obsolete packages and variables removed.


git-svn-id: http://15.206.35.175/svn/proteus/business-java/trunk@93104 ce508802-f39f-4f6c-b175-0d175dae99d5

webitm-dis/ibase/webitm/ejb/dis/adv/ConsumeOrderCnc.java

@@ -6,15 +6,17 @@
 */
 package ibase.webitm.ejb.dis.adv;
 
-import java.rmi.RemoteException;
-import java.sql.*;
-
-import javax.ejb.*;
+import ibase.system.config.ConnDriver;
+import ibase.webitm.ejb.ActionHandlerEJB;
+import ibase.webitm.ejb.ITMDBAccessEJB;
 import ibase.webitm.utility.ITMException;
-import ibase.webitm.ejb.*;
-import ibase.system.config.*;
 
-import javax.ejb.Stateless; // added for ejb3
+import java.rmi.RemoteException;
+import java.sql.Connection;
+import java.sql.PreparedStatement;
+import java.sql.ResultSet;
+
+import javax.ejb.Stateless;
 
 @Stateless // added for ejb3
 public class ConsumeOrderCnc extends ActionHandlerEJB implements ConsumeOrderCncLocal, ConsumeOrderCncRemote
@@ -55,7 +57,6 @@ public class ConsumeOrderCnc extends ActionHandlerEJB implements ConsumeOrderCnc
 	private String actionCancel(String consOrd ,String xtraParams)throws ITMException
 	{
 		Connection conn = null;
-		Statement stmt = null;
 		PreparedStatement pstmt =null;
 		ResultSet rs = null;
 		String sql = "";
@@ -69,18 +70,22 @@ public class ConsumeOrderCnc extends ActionHandlerEJB implements ConsumeOrderCnc
 		try
 		{	
 		   	conn = connDriver.getConnectDB("DriverITM");
-			stmt = conn.createStatement();
-			sql = "SELECT STATUS FROM CONSUME_ORD WHERE CONS_ORDER ='"+consOrd+"'";
+			
+			sql = "SELECT STATUS FROM CONSUME_ORD WHERE CONS_ORDER = ? ";
+			pstmt = conn.prepareStatement(sql);
+			pstmt.setString(1,consOrd);
+			rs = pstmt.executeQuery();
+			
 			System.out.println("ConsumeOrdCanc:actionCancel:sql:"+sql);
-			rs = stmt.executeQuery(sql);
+			
 			if(rs.next())
 			{
 				status = rs.getString("STATUS");
 			}
 			rs.close();
 			rs = null;
-			stmt.close();
-			stmt = null;
+			pstmt.close();
+			pstmt = null;
 			
 			System.out.println("consOrd:"+consOrd+":status:"+status+":");
 			if(status != null && status.trim().length() > 0 )
@@ -95,27 +100,36 @@ public class ConsumeOrderCnc extends ActionHandlerEJB implements ConsumeOrderCnc
 				}
 				else
 			    {
-					/* Added by sandesh to check if record is not confirmed. For such record system will 
-					*     show error message and cancellation wont proceed
+					/* Added by Sandesh to check if any record is not confirmed for given consumption order
+					*  In such a case system will show an error message and order cancellation won't proceed.
 					*  Date - 20/MAY/2013
-					* */
+					*/
 					 
 					String confirmed = null;
 					
-					stmt = conn.createStatement();
-					sql = "SELECT CONFIRMED FROM CONSUME_ISS WHERE CONS_ORDER = '"+consOrd+"'";
+					sql = "SELECT case when confirmed is null then 'N' else confirmed END "+
+							" FROM CONSUME_ISS WHERE CONS_ORDER = ? ";
+					
+					pstmt = conn.prepareStatement(sql);
+					pstmt.setString(1,consOrd);
+					rs = pstmt.executeQuery();
+					
 					System.out.println("ConsumeOrdCanc:actionCancel:confirmchk sql:"+sql);
-					rs = stmt.executeQuery(sql);
-					if(rs.next())
-					{
-						confirmed = rs.getString("CONFIRMED");
-					}
+
+					while(rs.next()){
+						
+						confirmed = rs.getString(1);
 						System.out.println("CONFIRMED for cancellation : "+confirmed);
 						
+						if(confirmed.equalsIgnoreCase("N"))
+							break;
+					}
+					
+					
 					rs.close();
 					rs = null;
-					stmt.close();
-					stmt = null;
+					pstmt.close();
+					pstmt = null;
 					
 					if(confirmed!=null&&confirmed.equalsIgnoreCase("N")){
 						
@@ -169,11 +183,6 @@ public class ConsumeOrderCnc extends ActionHandlerEJB implements ConsumeOrderCnc
 					rs.close();
 					rs = null;
 				}
-				if (stmt != null)
-				{
-					stmt.close();
-					stmt = null;
-				}
 				if (pstmt != null)
 				{
 					pstmt.close();