changed stmt to pstmt, added finally block and chnages

git-svn-id: http://15.206.35.175/svn/proteus/business-java/trunk@196571 ce508802-f39f-4f6c-b175-0d175dae99d5

webitm-dis/ibase/webitm/ejb/dis/DistCommon.java

@@ -97,8 +97,8 @@ public class DistCommon {
 		String taxClass = "";
 		String taxEnv = "";
 		String returnVlaue = "";
-		Statement stmt = null;
-		Statement stmt2 = null;
+		//Statement stmt = null;
+		//Statement stmt2 = null;
 		PreparedStatement pstmt = null;
 		ResultSet rs = null;
 		ResultSet rs2 = null;
@@ -238,8 +238,8 @@ public class DistCommon {
 											+ "WHERE TRAN_TYPE = '"
 											+ tranType
 											+ "'";
-									stmt = conn.createStatement();
-									rs = stmt.executeQuery(sql);
+									pstmt = conn.prepareStatement(sql);//stmt changed to pstmt
+									rs = pstmt.executeQuery();
 									if (rs.next()) {
 										priceList = rs.getString(1);
 										System.out.println("PriceList6 :-["
@@ -247,8 +247,8 @@ public class DistCommon {
 									}// if
 									rs.close();
 									rs = null;
-									stmt.close();
-									stmt = null;
+									pstmt.close();
+									pstmt = null;
 								}// if 5
 							}// if 4
 						}// if 3
@@ -416,8 +416,8 @@ public class DistCommon {
 											+ "WHERE TRAN_TYPE = '"
 											+ tranType
 											+ "'";
-									stmt = conn.createStatement();
-									rs = stmt.executeQuery(sql);
+									pstmt = conn.prepareStatement(sql);//stmt changed to pstmt
+									rs = pstmt.executeQuery();
 									if (rs.next()) {
 										priceListCLG = rs.getString(1);
 										System.out.println("PriceListCLG6:-["
@@ -426,8 +426,8 @@ public class DistCommon {
 									}// if
 									rs.close();
 									rs = null;
-									stmt.close();
-									stmt = null;
+									pstmt.close();
+									pstmt = null;
 								}// if 5
 							}// if 4
 						}// if 3
@@ -575,6 +575,7 @@ public class DistCommon {
 																+ itemSer);
 											}
 											rs2.close();
+											rs2 = null;
 											pstmt.close();
 											pstmt = null;
 											if ((itemSer == null)
@@ -603,6 +604,7 @@ public class DistCommon {
 																		+ itemSer);
 													}
 													rs2.close();
+													rs2 = null;
 													pstmt.close();
 													pstmt = null;
 												} catch (Exception ex) {
@@ -761,6 +763,7 @@ public class DistCommon {
 																					+ taxClass);
 																}// if
 																rs.close();
+																rs = null;
 																pstmt.close();
 																pstmt = null;
 																// stmt.close();
@@ -942,6 +945,7 @@ public class DistCommon {
 													+ itemSer);
 								}
 								rs2.close();
+								rs2 = null;
 								pstmt.close();
 								pstmt = null;
 								if ((itemSer == null)
@@ -965,6 +969,7 @@ public class DistCommon {
 															+ itemSer);
 										}
 										rs2.close();
+										rs2 = null;
 										pstmt.close();
 										pstmt = null;
 									} catch (Exception ex) {
@@ -1086,6 +1091,7 @@ public class DistCommon {
 															+ taxEnv);
 										}// if
 										rs.close();
+										rs = null;
 										pstmt.close();
 										pstmt = null;
 									}// if 6
@@ -1135,24 +1141,24 @@ public class DistCommon {
 		String retVal = null;
 		String sql = null;
 		ResultSet rs = null;
-		Statement stmt = null;
+		PreparedStatement pstmt = null;//stmt changed to pstmt
 		try {
-			System.out
-					.println("Finding the variable value from Disparam for parameters["
-							+ prdCode + "," + varName + "]");
-			stmt = conn.createStatement();
-			sql = "SELECT VAR_VALUE FROM DISPARM WHERE PRD_CODE ='" + prdCode
-					+ "' AND VAR_NAME ='" + varName + "'";
-			rs = stmt.executeQuery(sql);
+			System.out.println("Finding the variable value from Disparam for parameters["+ prdCode + "," + varName + "]");			
+			//sql = "SELECT VAR_VALUE FROM DISPARM WHERE PRD_CODE ='" + prdCode	+ "' AND VAR_NAME ='" + varName + "'";
+			sql = "SELECT VAR_VALUE FROM DISPARM WHERE PRD_CODE = ? AND VAR_NAME = ? ";
+			pstmt = conn.prepareStatement(sql);//stmt changed to pstmt
+			pstmt.setString(1, prdCode);
+			pstmt.setString(2, varName);
+			rs = pstmt.executeQuery();
 			if (rs.next()) {
 				retVal = (rs.getString(1) == null ? " " : rs.getString(1));
 			} else {
 				retVal = "NULLFOUND";
 			}
 			rs.close();
-			stmt.close();
 			rs = null;
-			stmt = null;
+			pstmt.close();			
+			pstmt = null;
 		} catch (Exception e) {
 			e.printStackTrace();
 		}
@@ -1174,14 +1180,15 @@ public class DistCommon {
 			throws ITMException {
 		String listType = "";
 		String sql = "";
-		Statement stmt = null;
+		PreparedStatement pstmt = null; //stmt chnaged to pstmt
 		ResultSet rs = null;
 		try {
-			sql = "SELECT LIST_TYPE FROM PRICELIST_MST WHERE PRICE_LIST = '"
-					+ priceList + "'";
+			sql = "SELECT LIST_TYPE FROM PRICELIST_MST WHERE PRICE_LIST = ? "; 	// '"
+					//+ priceList + "'";
 			System.out.println(sql);
-			stmt = conn.createStatement();
-			rs = stmt.executeQuery(sql);
+			pstmt = conn.prepareStatement(sql);
+			pstmt.setString(1, priceList);
+			rs = pstmt.executeQuery();
 			// System.out.println("LIST_TYPE... sql..."+sql);
 			// 25052007
 			if (rs.next()) {
@@ -1189,8 +1196,8 @@ public class DistCommon {
 			}
 			rs.close();
 			rs = null;
-			stmt.close();
-			stmt = null;
+			pstmt.close();
+			pstmt = null;
 			// System.out.println("listType...................."+listType);
 		} catch (Exception e) {
 			System.out.println("Exception...[getPriceListType] " + sql
@@ -2289,18 +2296,20 @@ public class DistCommon {
 		try {
 			sql = "SELECT COUNT(*) AS COUNT FROM UOM WHERE UNIT = '" + aunit
 					+ "'";
-			stmt = conn.createStatement();
-			rs = stmt.executeQuery(sql);
+			//stmt = conn.createStatement();
+			pstmt = conn.prepareStatement(sql);
+			rs = pstmt.executeQuery();
+			//rs = stmt.executeQuery(sql);
 			if (rs.next()) {
 				cnt = rs.getInt("COUNT");
 			}
+			rs.close();
+			pstmt.close();
+			pstmt = null;
+			rs = null;
 			if (cnt == 0) {
 				return -1;
 			}			
-			rs.close();
-			stmt.close();
-			stmt = null;
-			rs = null;
 		} catch (Exception e) {
 			System.out
 					.println("Exception...[pickRate] " + sql + e.getMessage());
@@ -5235,11 +5244,11 @@ public class DistCommon {
 					if (rs.next()) {
 						rate = rs.getDouble(1);
 						// System.out.println("Rate is .*...."+rate);						
+					}
 					rs.close();
 					rs = null;
 					pstmt.close();
 					pstmt = null;
-					}
 				}// try
 				catch (Exception e) {
 					System.out.println("Exception...[pickRate] " + sql
@@ -5952,71 +5961,78 @@ public class DistCommon {
 
 		try {
 			sql = "select integral_qty  from customeritem "
-					+ " where cust_code = '" + custCode + "' "
-					+ "and item_code = '" + itemCode + "' ";
+					+ " where cust_code = ? " //'" + custCode + "' "
+					+ "and item_code = ? "; //'" + itemCode + "' ";
 			pstmt = conn.prepareStatement(sql);
+			pstmt.setString(1, custCode);
+			pstmt.setString(2, itemCode);
 			rs = pstmt.executeQuery();
 			if (rs.next()) {
 				intQty = rs.getDouble(1);
 				System.out.println("intQty........" + intQty);
 			}
-			pstmt.close();
-			pstmt = null;
 			rs.close();
 			rs = null;
+			pstmt.close();
+			pstmt = null;			
 			if (intQty == 0) {
 				sql = "select integral_qty  from siteitem "
-						+ " where site_code = '" + siteCode + "' "
-						+ " and item_code = '" + itemCode + "' ";
+						+ " where site_code = ? "	//'" + siteCode + "' "
+						+ " and item_code = ?"; 	//'" + itemCode + "' ";
 				pstmt = conn.prepareStatement(sql);
+				pstmt.setString(1, siteCode);
+				pstmt.setString(2, itemCode);
 				rs = pstmt.executeQuery();
 				if (rs.next()) {
 					intQty = rs.getDouble(1);
 
 				}
-				pstmt.close();
-				pstmt = null;
 				rs.close();
 				rs = null;
+				pstmt.close();
+				pstmt = null;				
 				if (intQty == 0) {
 					sql = "select integral_qty  from item "
-							+ "where item_code = '" + itemCode + "' ";
+							+ "where item_code = ?";	//'" + itemCode + "' ";
 					pstmt = conn.prepareStatement(sql);
+					pstmt.setString(1, itemCode);
 					rs = pstmt.executeQuery();
 					if (rs.next()) {
 						intQty = rs.getDouble(1);
 
 					}
-					pstmt.close();
-					pstmt = null;
 					rs.close();
 					rs = null;
+					pstmt.close();
+					pstmt = null;					
 					if (intQty == 0) {
-						sql = "select count(*)  from item where item_code = '"
-								+ itemCode + "' ";
+						sql = "select count(*)  from item where item_code = ? ";// '"
+								//+ itemCode + "' ";
 						pstmt = conn.prepareStatement(sql);
+						pstmt.setString(1, itemCode);
 						rs = pstmt.executeQuery();
 						if (rs.next()) {
 							cnt = rs.getInt(1);
 
 						}
-						pstmt.close();
-						pstmt = null;
 						rs.close();
 						rs = null;
+						pstmt.close();
+						pstmt = null;						
 						if (cnt == 0) {
 							sql = "select batch_qty  from bom "
-									+ " where bom_code ='" + itemCode + "' ";
+									+ " where bom_code =? "; 	//'" + itemCode + "' ";
 							pstmt = conn.prepareStatement(sql);
+							pstmt.setString(1, itemCode);
 							rs = pstmt.executeQuery();
 							if (rs.next()) {
 								intQty = rs.getDouble(1);
 
 							}
-							pstmt.close();
-							pstmt = null;
 							rs.close();
 							rs = null;
+							pstmt.close();
+							pstmt = null;							
 						}
 					}
 
@@ -7533,6 +7549,29 @@ public class DistCommon {
 					+ e.getMessage());
 			e.printStackTrace();
 			throw new ITMException(e);
+		}finally{
+			
+			try{
+				if(rs != null)	{	
+					rs.close();
+					rs = null;
+				}
+				if( pstmt != null)	{
+					pstmt.close();
+					pstmt = null;
+				}
+				if( rs1 != null) {
+					rs1.close();
+					rs1 = null;
+				}
+				if( pstmt1 != null)	{
+					pstmt1.close();
+					pstmt1 = null;
+				}								
+			}catch(Exception e)
+			{				
+			}
+			
 		}
 		return errString;
 	}
@@ -7563,14 +7602,13 @@ public class DistCommon {
 			if (rs.next()) {
 				llCount = rs.getInt("cnt");
 			}
-
-			if (llCount == 0) {
-				return "";
-			}
 			rs.close();
 			rs = null;
 			pstmt.close();
 			pstmt = null;
+			if (llCount == 0) {
+				return "";
+			}			
 
 			sql = "Select Check_integral_qty ls_check_integral_qty From distorder_type Where tran_type = '"
 					+ lsTranType.trim() + "'";
@@ -11807,6 +11845,10 @@ public class DistCommon {
 						}
 					}
 				}
+				rs.close();
+				rs = null;
+				pstmt.close();
+				pstmt = null;
 				if(getDoubleValue(finalRate) <= 0)
 				{
 					errCode = "VTRATE2";