Commit e1b2f16f authored by Ajit Deshmukh's avatar Ajit Deshmukh

Resovled the issues reported by the QC on Support/Implementation transaction...

Resovled the issues reported by the QC on Support/Implementation transaction confirmation the SQL is not executed on the DB and Added the validation for For Review Case
parent babb6487
/** /**
* PURPOSE : Home screen confirm comp * PURPOSE : Home screen confirm comp
* AUTHOR : Mrunalini Sinkar * AUTHOR : Mrunalini Sinkar
*/ */
package ibase.webitm.ejb.sys; package ibase.webitm.ejb.sys;
import ibase.system.config.ConnDriver; import ibase.system.config.ConnDriver;
import ibase.utility.BaseLogger; import ibase.utility.BaseLogger;
import ibase.webitm.ejb.ActionHandlerEJB; import ibase.webitm.ejb.ActionHandlerEJB;
import ibase.webitm.ejb.ITMDBAccessEJB; import ibase.webitm.ejb.ITMDBAccessEJB;
import ibase.webitm.ejb.ValidatorEJB; import ibase.webitm.ejb.ValidatorEJB;
import ibase.webitm.utility.GenericUtility; import ibase.webitm.utility.GenericUtility;
import ibase.webitm.utility.ITMException; import ibase.webitm.utility.ITMException;
import java.rmi.RemoteException; import java.rmi.RemoteException;
import java.sql.*; import java.sql.*;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.Collections; import java.util.Collections;
import java.util.HashMap; import java.util.HashMap;
import java.util.Iterator; import java.util.Iterator;
import java.util.LinkedHashMap; import java.util.LinkedHashMap;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.regex.Matcher; import java.util.regex.Matcher;
import java.util.regex.Pattern; import java.util.regex.Pattern;
import ibase.webitm.utility.TransIDGenerator; import ibase.webitm.utility.TransIDGenerator;
import ibase.utility.CommonConstants; import ibase.utility.CommonConstants;
import ibase.utility.E12GenericUtility; import ibase.utility.E12GenericUtility;
import ibase.utility.UserInfoBean; import ibase.utility.UserInfoBean;
public class ManageSqlConf extends ActionHandlerEJB { public class ManageSqlConf extends ActionHandlerEJB {
int reUpdateCnt = 0; int reUpdateCnt = 0;
String sqlError = ""; String sqlError = "";
...@@ -75,8 +75,10 @@ public class ManageSqlConf extends ActionHandlerEJB { ...@@ -75,8 +75,10 @@ public class ManageSqlConf extends ActionHandlerEJB {
String tranIdRef = ""; String tranIdRef = "";
String selectedEnterprise = ""; String selectedEnterprise = "";
String confirmed = ""; String confirmed = "";
String reviewYn = "";
String txnStatus = "";
String checkSql = "SELECT tran_id__ref,EXEC_RIGHTS,enterprises,confirmed FROM SQL_CHANGES WHERE TRAN_ID = ?"; String checkSql = "SELECT tran_id__ref,EXEC_RIGHTS,enterprises,confirmed,review_yn,txn_status FROM SQL_CHANGES WHERE TRAN_ID = ?";
pstmt = con.prepareStatement(checkSql); pstmt = con.prepareStatement(checkSql);
pstmt.setString(1, tranId); pstmt.setString(1, tranId);
rs = pstmt.executeQuery(); rs = pstmt.executeQuery();
...@@ -85,6 +87,8 @@ public class ManageSqlConf extends ActionHandlerEJB { ...@@ -85,6 +87,8 @@ public class ManageSqlConf extends ActionHandlerEJB {
execRights = checkNull(rs.getString("EXEC_RIGHTS")); execRights = checkNull(rs.getString("EXEC_RIGHTS"));
selectedEnterprise = checkNull(rs.getString("enterprises")); selectedEnterprise = checkNull(rs.getString("enterprises"));
confirmed = checkNull(rs.getString("confirmed")); confirmed = checkNull(rs.getString("confirmed"));
reviewYn = checkNull(rs.getString("review_yn"));
txnStatus = checkNull(rs.getString("txn_status"));
} }
if (rs != null) { if (rs != null) {
...@@ -106,6 +110,22 @@ public class ManageSqlConf extends ActionHandlerEJB { ...@@ -106,6 +110,22 @@ public class ManageSqlConf extends ActionHandlerEJB {
errString = itmdbAccessLocal.getErrorString("confirmed", "VTCICONF1", "", "", con); errString = itmdbAccessLocal.getErrorString("confirmed", "VTCICONF1", "", "", con);
return errString; return errString;
} }
String profileId = checkNull(getUserInfo().getProfileId());
BaseLogger.log("3", null, null, "Profile Id of User profileId:: " + profileId);
BaseLogger.log("3", null, null, " txnStatus:: " + txnStatus);
BaseLogger.log("3", null, null, " reviewYn:: " + reviewYn);
if (profileId.trim().equalsIgnoreCase("MSIMPLSUP")) {
tranIdRef = tranId;
if (reviewYn.trim().equalsIgnoreCase("Y") && !txnStatus.trim().equalsIgnoreCase("N")) {
BaseLogger.log("3", null, null, "Transaction Not reviewed");
errString = itmdbAccessLocal.getErrorString("confirmed", "MSQLNR", "", "", con);
return errString; // Stop execution here
}
}
BaseLogger.log("3", null, null, "tranIdRef:: " + tranIdRef);
// Commented by Ajit D. on 03-DEC-25 -- START // Commented by Ajit D. on 03-DEC-25 -- START
// if ("Q".equalsIgnoreCase(execRights)) { // if ("Q".equalsIgnoreCase(execRights)) {
// System.out.println("This transaction has exec_rights = 'D'"); // System.out.println("This transaction has exec_rights = 'D'");
...@@ -2097,7 +2117,8 @@ public class ManageSqlConf extends ActionHandlerEJB { ...@@ -2097,7 +2117,8 @@ public class ManageSqlConf extends ActionHandlerEJB {
" FOR " + schemaForMain + "." + objectName; " FOR " + schemaForMain + "." + objectName;
executeAndLog( executeAndLog(
schemaName, // schemaName,
dbMain,
synonymSql, synonymSql,
tranId, tranId,
enterpriseCode, enterpriseCode,
...@@ -2192,7 +2213,8 @@ public class ManageSqlConf extends ActionHandlerEJB { ...@@ -2192,7 +2213,8 @@ public class ManageSqlConf extends ActionHandlerEJB {
if (grantSql != null) { if (grantSql != null) {
executeAndLog( executeAndLog(
schemaName, // schemaName
dbMain,
grantSql, grantSql,
tranId, tranId,
enterpriseCode, enterpriseCode,
...@@ -2434,7 +2456,7 @@ public class ManageSqlConf extends ActionHandlerEJB { ...@@ -2434,7 +2456,7 @@ public class ManageSqlConf extends ActionHandlerEJB {
"CONNECTED USER ::: " "CONNECTED USER ::: "
+ connForQueryExec.getMetaData().getUserName()); + connForQueryExec.getMetaData().getUserName());
System.out.println( System.out.println(
"CONNECTED URL ::: " "CONNECTED URL ::: "
+ connForQueryExec.getMetaData().getURL()); + connForQueryExec.getMetaData().getURL());
} catch (Exception e) { } catch (Exception e) {
...@@ -3049,4 +3071,4 @@ System.out.println( ...@@ -3049,4 +3071,4 @@ System.out.println(
return null; return null;
} }
} }
\ No newline at end of file \ No newline at end of file
...@@ -475,3 +475,8 @@ Insert into MESSAGES (MSG_NO,MSG_STR,MSG_DESCR,MSG_TYPE,MSG_OPT,MSG_TIME,ALARM,E ...@@ -475,3 +475,8 @@ Insert into MESSAGES (MSG_NO,MSG_STR,MSG_DESCR,MSG_TYPE,MSG_OPT,MSG_TIME,ALARM,E
Insert into SYSTEM_EVENTS (OBJ_NAME,EVENT_CODE,EVENT_CONTEXT,SERVICE_CODE,METHOD_RULE,OVERWRITE_CORE,CHG_DATE,CHG_USER,CHG_TERM,RESULT_HANDLE,COMP_TYPE,COMP_NAME,COMM_FORMAT,FIELD_NAME,FORM_NO) values ('sql_changes','pre_proc_post_item_change','2','post_gen_val',null,'0',to_date('28-SEP-21','DD-MON-RR'),'system ','system','2','JB','ibase.webitm.ejb.sys.GenValidate',null,null,null); Insert into SYSTEM_EVENTS (OBJ_NAME,EVENT_CODE,EVENT_CONTEXT,SERVICE_CODE,METHOD_RULE,OVERWRITE_CORE,CHG_DATE,CHG_USER,CHG_TERM,RESULT_HANDLE,COMP_TYPE,COMP_NAME,COMM_FORMAT,FIELD_NAME,FORM_NO) values ('sql_changes','pre_proc_post_item_change','2','post_gen_val',null,'0',to_date('28-SEP-21','DD-MON-RR'),'system ','system','2','JB','ibase.webitm.ejb.sys.GenValidate',null,null,null);
--------10th July------------
update messages set MSG_DESCR = 'This transaction cannot be confirmed until an execution environment is assigned.' where msg_no = 'MSQLBER';
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment