Skip to content

C
Component Sharing
Commit c1ac2910 authored by Ajit Deshmukh's avatar Ajit Deshmukh
Browse files
Options

Add return statement in catch block of connection object and sql select query... 

Add return statement in catch block of connection object and sql select query execution block for error message when connection did not established or wrong sql query.
parent c512d0c0
Hide whitespace changes
Inline Side-by-side
Showing with 302 additions and 72 deletions
Task/Mailing List/Java component/MailingListPostSave.java
View file @ c1ac2910
...@@ -2,19 +2,27 @@ package ibase.marketingCampaign; ...@@ -2,19 +2,27 @@ package ibase.marketingCampaign;
import java.rmi.RemoteException; import java.rmi.RemoteException;
import java.sql.Connection; import java.sql.Connection;
import java.sql.PreparedStatement;
import java.util.*; import java.sql.ResultSet;
import java.sql.*; import java.sql.SQLException;
import org.w3c.dom.Document; import org.w3c.dom.Document;
import org.w3c.dom.*;
import ibase.ejb.CommonDBAccessEJB;
import ibase.system.config.ConnDriver;
import ibase.utility.BaseException;
import ibase.utility.BaseLogger; import ibase.utility.BaseLogger;
import ibase.utility.E12GenericUtility; import ibase.utility.E12GenericUtility;
import ibase.utility.UserInfoBean;
import ibase.webitm.ejb.ActionHandlerEJB;
import ibase.webitm.ejb.ITMDBAccessEJB;
import ibase.webitm.ejb.ValidatorEJB; import ibase.webitm.ejb.ValidatorEJB;
import ibase.webitm.utility.ITMException; import ibase.webitm.utility.ITMException;
public class MailingListPostSave extends ValidatorEJB { public class MailingListPostSave extends ValidatorEJB {
ActionHandlerEJB actionHandlerEJB = new ActionHandlerEJB();
E12GenericUtility genericUtility = new E12GenericUtility();
ITMDBAccessEJB itmDBAccessEJB = new ITMDBAccessEJB();
public String postSave() throws RemoteException, ITMException { public String postSave() throws RemoteException, ITMException {
return ""; return "";
...@@ -23,86 +31,308 @@ public class MailingListPostSave extends ValidatorEJB { ...@@ -23,86 +31,308 @@ public class MailingListPostSave extends ValidatorEJB {
public String postSave(String domString, String editFlag, String xtraParams, Connection conn) throws RemoteException, ITMException { public String postSave(String domString, String editFlag, String xtraParams, Connection conn) throws RemoteException, ITMException {
System.out.println("In VoucherPostSave ... "); System.out.println("In VoucherPostSave ... ");
BaseLogger.log("3", null, null, "In MailingListPreSave method "); BaseLogger.log("3", null, null, "In MailingListPreSave method ");
Document dom = null;
String errorString="";
String retString = "";
ConnDriver connDriver = new ConnDriver();
try {
if (domString != null && domString.trim().length() != 0) {
dom = genericUtility.parseString(domString);
}
}catch (Exception e) {
System.out.println("Exception :SfaTime :itemChanged(String,String):" + e.getMessage() + ":");
errorString = genericUtility.createErrorString(e);
}
String mailListType = checkNull(genericUtility.getColumnValue("mail_list_type", dom));
BaseLogger.log("3", null, null, "MailingListPostSave : DOM :: [" + mailListType + "]");
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
PreparedStatement pstmt2 = null; PreparedStatement pstmt2 = null;
PreparedStatement pstmt3 = null; PreparedStatement pstmt3 = null;
Document dom = null; String userId = "";
//Document dom = null;
ResultSet rs = null; ResultSet rs = null;
boolean isError = false; boolean isError = false;
String selectSQLStr = ""; // this query will get name and email ID. String selectSQLStr = ""; // this query will get name and email ID.
String MailListID = ""; String MailListID = "";
//String errorString ="";
if ("S".equalsIgnoreCase(mailListType)) {
try {
// Delete existing records
String deleteSQL = "DELETE FROM mailing_list_det";
pstmt3 = conn.prepareStatement(deleteSQL);
int rowsDeleted = pstmt3.executeUpdate();
BaseLogger.log("3", null, null, "MailingListPostSave : Deleted rows count :: [" + rowsDeleted + "]");
conn.commit();
try { E12GenericUtility genericUtility = new E12GenericUtility();
// Delete existing records dom = genericUtility.parseString(domString);
String deleteSQL = "DELETE FROM mailing_list_det"; BaseLogger.log("3", null, null, "MailingListPostSave : DOM :: [" + dom + "]");
pstmt3 = conn.prepareStatement(deleteSQL); selectSQLStr = genericUtility.getColumnValue("sql_str", dom);
int rowsDeleted = pstmt3.executeUpdate(); BaseLogger.log("3", null, null, "MailingListPostSave : sql value :: [" + selectSQLStr + "]");
BaseLogger.log("3", null, null, "MailingListPostSave : Deleted rows count :: [" + rowsDeleted + "]"); MailListID = genericUtility.getColumnValue("mail_list_id", dom);
conn.commit(); BaseLogger.log("3", null, null, "MailingListPostSave : mail_list_id :: [" + MailListID + "]");
E12GenericUtility genericUtility = new E12GenericUtility(); pstmt = conn.prepareStatement(selectSQLStr);
dom = genericUtility.parseString(domString); rs = pstmt.executeQuery();
BaseLogger.log("3", null, null, "MailingListPostSave : DOM :: [" + dom + "]");
selectSQLStr = genericUtility.getColumnValue("sql_str", dom); int rowCount = 0;
BaseLogger.log("3", null, null, "MailingListPostSave : sql value :: [" + selectSQLStr + "]"); int lineNo = 1;
MailListID = genericUtility.getColumnValue("mail_list_id", dom); String[] selectParts = selectSQLStr.toLowerCase().split("from")[0].replace("select", "").trim().split(",");
BaseLogger.log("3", null, null, "MailingListPostSave : mail_list_id :: [" + MailListID + "]"); String firstColumn = selectParts[0].trim();
String secondColumn = selectParts.length > 1 ? selectParts[1].trim() : "";
pstmt = conn.prepareStatement(selectSQLStr);
rs = pstmt.executeQuery(); BaseLogger.log("3", null, null, "MailingListPostSave : mail_list_id :: [" + firstColumn + "]");
BaseLogger.log("3", null, null, "MailingListPostSave : mail_list_id :: [" + secondColumn + "]");
int rowCount = 0;
int lineNo = 1; pstmt2 = conn.prepareStatement("INSERT INTO mailing_list_det (MAIL_LIST_ID, LINE_NO, EMAIL_ID, NAME) VALUES (?, ?, ?, ?)");
String[] selectParts = selectSQLStr.toLowerCase().split("from")[0].replace("select", "").trim().split(","); while (rs.next()) {
String firstColumn = selectParts[0].trim(); rowCount++;
String secondColumn = selectParts.length > 1 ? selectParts[1].trim() : ""; String name = rs.getString(firstColumn);
String emailId = rs.getString(secondColumn);
BaseLogger.log("3", null, null, "MailingListPostSave : mail_list_id :: [" + firstColumn + "]"); BaseLogger.log("3", null, null, "MailingListPostSave : name :: [" + name + "]");
BaseLogger.log("3", null, null, "MailingListPostSave : mail_list_id :: [" + secondColumn + "]"); BaseLogger.log("3", null, null, "MailingListPostSave : emailId :: [" + emailId + "]");
pstmt2 = conn.prepareStatement("INSERT INTO mailing_list_det (MAIL_LIST_ID, LINE_NO, EMAIL_ID, NAME) VALUES (?, ?, ?, ?)"); pstmt2.setString(1, MailListID);
while (rs.next()) { pstmt2.setInt(2, lineNo);
rowCount++; pstmt2.setString(3, emailId);
String name = rs.getString(firstColumn); pstmt2.setString(4, name);
String emailId = rs.getString(secondColumn); pstmt2.addBatch(); // Add to batch
BaseLogger.log("3", null, null, "MailingListPostSave : name :: [" + name + "]"); lineNo++;
BaseLogger.log("3", null, null, "MailingListPostSave : emailId :: [" + emailId + "]");
// Execute batch every 100 inserts (or adjust as needed)
pstmt2.setString(1, MailListID); if (lineNo % 100 == 0) {
pstmt2.setInt(2, lineNo); pstmt2.executeBatch();
pstmt2.setString(3, emailId); pstmt2.clearBatch(); // Clear the batch after execution
pstmt2.setString(4, name); }
pstmt2.addBatch(); // Add to batch }
lineNo++; // Execute any remaining batch
pstmt2.executeBatch();
// Execute batch every 100 inserts (or adjust as needed)
if (lineNo % 100 == 0) { BaseLogger.log("3", null, null, "MailingListPostSave : Total rows in result set :: [" + rowCount + "]");
pstmt2.executeBatch(); conn.commit();
pstmt2.clearBatch(); // Clear the batch after execution BaseLogger.log("3", null, null, "MailingListPostSave : All inserts completed!");
}
} } catch (Exception e) {
// Execute any remaining batch BaseLogger.log("3", null, null, "MailingListPostSave : exception in try block: " + e.getMessage());
pstmt2.executeBatch(); // errorString = getErrorString("email_id", "SQLIM", userId);
isError = true;
BaseLogger.log("3", null, null, "MailingListPostSave : Total rows in result set :: [" + rowCount + "]");
conn.commit(); } finally {
BaseLogger.log("3", null, null, "MailingListPostSave : All inserts completed!"); // Closing resources properly
if (rs != null) try { rs.close(); } catch (SQLException e) { BaseLogger.log("3", null, null, "MailingListPostSave : in catch"); }
} catch (Exception e) { if (pstmt != null) try { pstmt.close(); } catch (SQLException e) { BaseLogger.log("3", null, null, "MailingListPostSave : in catch"); }
BaseLogger.log("3", null, null, "MailingListPostSave : exception in try block: " + e.getMessage()); if (pstmt2 != null) try { pstmt2.close(); } catch (SQLException e) { BaseLogger.log("3", null, null, "MailingListPostSave : in catch"); }
isError = true; if (pstmt3 != null) try { pstmt3.close(); } catch (SQLException e) { BaseLogger.log("3", null, null, "MailingListPostSave : in catch"); }
}
} finally {
// Close resources properly }
if (rs != null) try { rs.close(); } catch (SQLException e) { BaseLogger.log("3", null, null, "MailingListPostSave : in catch"); }
if (pstmt != null) try { pstmt.close(); } catch (SQLException e) { BaseLogger.log("3", null, null, "MailingListPostSave : in catch"); } // -------------------------------------
if (pstmt2 != null) try { pstmt2.close(); } catch (SQLException e) { BaseLogger.log("3", null, null, "MailingListPostSave : in catch"); }
if (pstmt3 != null) try { pstmt3.close(); } catch (SQLException e) { BaseLogger.log("3", null, null, "MailingListPostSave : in catch"); } if("I".equalsIgnoreCase(mailListType)) {
Connection dremioConn = null;
PreparedStatement dremioPstmt = null;
ResultSet DremioRs = null;
userId = getValueFromXTRA_PARAMS(xtraParams, "loginCode");
CommonDBAccessEJB commonDBAccessEJB = new CommonDBAccessEJB();
try {
setUserInfo(commonDBAccessEJB.createUserInfo(userId));
} catch (BaseException e1) {
e1.printStackTrace();
} catch (Exception e1) {
e1.printStackTrace();
}
String transDB = getUserInfo().getTransDB();
// String transDB = userInfo.getTransDB();
BaseLogger.log("3", null, null, "MailingListPostSave : Deleted rows count :: [" + transDB + "]");
try {
dremioConn = connDriver.getConnectDB(transDB+"_IN_MEM",true);
BaseLogger.log("3", null, null, "MailingListPostSave : Dream io connection established");
try {
// Delete existing records
String deleteSQL = "DELETE FROM mailing_list_det";
pstmt3 = conn.prepareStatement(deleteSQL);
int rowsDeleted = pstmt3.executeUpdate();
BaseLogger.log("3", null, null, "MailingListPostSave : Deleted rows count :: [" + rowsDeleted + "]");
conn.commit();
E12GenericUtility genericUtility = new E12GenericUtility();
dom = genericUtility.parseString(domString);
BaseLogger.log("3", null, null, "MailingListPostSave : DOM :: [" + dom + "]");
selectSQLStr = genericUtility.getColumnValue("sql_str", dom);
BaseLogger.log("3", null, null, "MailingListPostSave : sql value :: [" + selectSQLStr + "]");
MailListID = genericUtility.getColumnValue("mail_list_id", dom);
BaseLogger.log("3", null, null, "MailingListPostSave : mail_list_id :: [" + MailListID + "]");
//Added changes - Move execution of query in try-catch block.
try {
dremioPstmt = dremioConn.prepareStatement(selectSQLStr);
DremioRs = dremioPstmt.executeQuery();
}catch(Exception e) {
BaseLogger.log("3", null, null, "MailingListPostSave : exception in try block of select query: [" + E12GenericUtility.getStackTrace(e) + "]");
retString = itmDBAccessEJB.getErrorString("", "VTSQLSELE", "", "", conn);
return retString;
}
int rowCount = 0;
int lineNo = 1;
String[] selectParts = selectSQLStr.toLowerCase().split("from")[0].replace("select", "").trim().split(",");
String firstColumn = selectParts[0].trim();
String secondColumn = selectParts.length > 1 ? selectParts[1].trim() : "";
BaseLogger.log("3", null, null, "MailingListPostSave : mail_list_id :: [" + firstColumn + "]");
BaseLogger.log("3", null, null, "MailingListPostSave : mail_list_id :: [" + secondColumn + "]");
pstmt2 = conn.prepareStatement("INSERT INTO mailing_list_det (MAIL_LIST_ID, LINE_NO, EMAIL_ID, NAME) VALUES (?, ?, ?, ?)");
while (DremioRs.next()) {
rowCount++;
String name = DremioRs.getString(firstColumn);
String emailId = DremioRs.getString(secondColumn);
BaseLogger.log("3", null, null, "MailingListPostSave : name :: [" + name + "]");
BaseLogger.log("3", null, null, "MailingListPostSave : emailId :: [" + emailId + "]");
pstmt2.setString(1, MailListID);
pstmt2.setInt(2, lineNo);
pstmt2.setString(3, emailId);
pstmt2.setString(4, name);
pstmt2.addBatch(); // Add to batch
lineNo++;
// Execute batch every 100 inserts (or adjust as needed)
if (lineNo % 100 == 0) {
pstmt2.executeBatch();
pstmt2.clearBatch(); // Clear the batch after execution
}
}
// Execute any remaining batch
pstmt2.executeBatch();
BaseLogger.log("3", null, null, "MailingListPostSave : Total rows in result set :: [" + rowCount + "]");
conn.commit();
BaseLogger.log("3", null, null, "MailingListPostSave : All inserts completed!");
} catch (Exception e) {
BaseLogger.log("3", null, null, "MailingListPostSave : exception in try block: [" + E12GenericUtility.getStackTrace(e) + "]");
// errorString = getErrorString("email_id", "SQLIM", userId);
isError = true;
retString = itmDBAccessEJB.getErrorString("", "VTSQLSELE", "", "", conn);
return retString;
} finally {
// Closing resources properly
if (rs != null) try { rs.close(); } catch (SQLException e) { BaseLogger.log("3", null, null, "MailingListPostSave : in catch"); }
if (pstmt != null) try { pstmt.close(); } catch (SQLException e) { BaseLogger.log("3", null, null, "MailingListPostSave : in catch"); }
if (pstmt2 != null) try { pstmt2.close(); } catch (SQLException e) { BaseLogger.log("3", null, null, "MailingListPostSave : in catch"); }
if (pstmt3 != null) try { pstmt3.close(); } catch (SQLException e) { BaseLogger.log("3", null, null, "MailingListPostSave : in catch"); }
if (DremioRs != null) try { DremioRs.close(); } catch (SQLException e) { BaseLogger.log("3", null, null, "MailingListPostSave : in catch"); }
if (dremioPstmt != null) try { dremioPstmt.close(); } catch (SQLException e) { BaseLogger.log("3", null, null, "MailingListPostSave : in catch"); }
}
} catch (Exception e) {
BaseLogger.log("3", null, null, "MailingListPostSave : Exception in try block for In-Memory" + e.getClass().getCanonicalName() + " || " + e.getClass().getName());
e.printStackTrace();
retString = itmDBAccessEJB.getErrorString("", "CONNFAIL", "", "", conn);
return retString;
}
} }
// try {
// // Delete existing records
// String deleteSQL = "DELETE FROM mailing_list_det";
// pstmt3 = conn.prepareStatement(deleteSQL);
// int rowsDeleted = pstmt3.executeUpdate();
// BaseLogger.log("3", null, null, "MailingListPostSave : Deleted rows count :: [" + rowsDeleted + "]");
// conn.commit();
//
// E12GenericUtility genericUtility = new E12GenericUtility();
// dom = genericUtility.parseString(domString);
// BaseLogger.log("3", null, null, "MailingListPostSave : DOM :: [" + dom + "]");
// selectSQLStr = genericUtility.getColumnValue("sql_str", dom);
// BaseLogger.log("3", null, null, "MailingListPostSave : sql value :: [" + selectSQLStr + "]");
// MailListID = genericUtility.getColumnValue("mail_list_id", dom);
// BaseLogger.log("3", null, null, "MailingListPostSave : mail_list_id :: [" + MailListID + "]");
//
// pstmt = conn.prepareStatement(selectSQLStr);
// rs = pstmt.executeQuery();
//
// int rowCount = 0;
// int lineNo = 1;
// String[] selectParts = selectSQLStr.toLowerCase().split("from")[0].replace("select", "").trim().split(",");
// String firstColumn = selectParts[0].trim();
// String secondColumn = selectParts.length > 1 ? selectParts[1].trim() : "";
//
// BaseLogger.log("3", null, null, "MailingListPostSave : mail_list_id :: [" + firstColumn + "]");
// BaseLogger.log("3", null, null, "MailingListPostSave : mail_list_id :: [" + secondColumn + "]");
//
// pstmt2 = conn.prepareStatement("INSERT INTO mailing_list_det (MAIL_LIST_ID, LINE_NO, EMAIL_ID, NAME) VALUES (?, ?, ?, ?)");
// while (rs.next()) {
// rowCount++;
// String name = rs.getString(firstColumn);
// String emailId = rs.getString(secondColumn);
// BaseLogger.log("3", null, null, "MailingListPostSave : name :: [" + name + "]");
// BaseLogger.log("3", null, null, "MailingListPostSave : emailId :: [" + emailId + "]");
//
// pstmt2.setString(1, MailListID);
// pstmt2.setInt(2, lineNo);
// pstmt2.setString(3, emailId);
// pstmt2.setString(4, name);
// pstmt2.addBatch(); // Add to batch
// lineNo++;
//
// // Execute batch every 100 inserts (or adjust as needed)
// if (lineNo % 100 == 0) {
// pstmt2.executeBatch();
// pstmt2.clearBatch(); // Clear the batch after execution
// }
// }
// // Execute any remaining batch
// pstmt2.executeBatch();
//
// BaseLogger.log("3", null, null, "MailingListPostSave : Total rows in result set :: [" + rowCount + "]");
// conn.commit();
// BaseLogger.log("3", null, null, "MailingListPostSave : All inserts completed!");
//
// } catch (Exception e) {
// BaseLogger.log("3", null, null, "MailingListPostSave : exception in try block: " + e.getMessage());
// // errorString = getErrorString("email_id", "SQLIM", userId);
// isError = true;
//
// } finally {
// // Closing resources properly
// if (rs != null) try { rs.close(); } catch (SQLException e) { BaseLogger.log("3", null, null, "MailingListPostSave : in catch"); }
// if (pstmt != null) try { pstmt.close(); } catch (SQLException e) { BaseLogger.log("3", null, null, "MailingListPostSave : in catch"); }
// if (pstmt2 != null) try { pstmt2.close(); } catch (SQLException e) { BaseLogger.log("3", null, null, "MailingListPostSave : in catch"); }
// if (pstmt3 != null) try { pstmt3.close(); } catch (SQLException e) { BaseLogger.log("3", null, null, "MailingListPostSave : in catch"); }
// }
return ""; return "";
} }
private String checkNull(String input) {
if (input == null) {
input = "";
} else {
input = input.trim();
}
return input;
}
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment